Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" #716

Closed
wants to merge 2 commits into from

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Oct 17, 2020

Please review fix for the test issue. This test fails on machines with low display resolution.
Limiting of the length of the line to 30 characters prevents it from wrapping the line
for a second time which fixes the problem. I tested solution on different modes from 1024x768 to 3840x2160.

/cc swing


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/716/head:pull/716
$ git checkout pull/716

…d with "RuntimeException: Wrong caret position"
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 17, 2020

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 17, 2020

@azuev-java
The swing label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 17, 2020

Webrevs

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 17, 2020

Hi Alex,
With this modification, it passes even without the fix for JDK-8232243

Checked that it fails without the fix on all resolutions and passes with
fix on all resolutions.
@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Oct 17, 2020

Hi Alex,
With this modification, it passes even without the fix for JDK-8232243

Fixed. By shifting click position left i'm avoiding clicking an empty space on low resolution displays and test passes with fix and fails without it.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 17, 2020

Mailing list message from Alexander Zuev on swing-dev:

Fixed. Please check new version.

On 10/17/2020 3:09 AM, Prasanta Sadhukhan wrote:

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 17, 2020

ok. But since this is mach5 issue it will be better to get a mach5 stability check through a mach5 job running several iterations on all platforms.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 18, 2020

Mailing list message from Alexander Zuev on swing-dev:

I did that and i did a full sanity tier3 run - both showed no problem
with the test.
I will put job URLs into the bug comments.

On 10/17/2020 6:40 AM, Prasanta Sadhukhan wrote:

mrserb
mrserb approved these changes Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException:  Wrong caret position"

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 389 new commits pushed to the master branch:

  • 272bb5d: 8253455: Record Classes javax.lang.model changes
  • c17d585: 8246774: implement Record Classes as a standard feature in Java
  • 0b3e6c5: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails
  • ce1aac1: 8028707: javax/swing/JComboBox/6236162/bug6236162.java fails on azure
  • 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
  • e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
  • 402d01a: 8254795: Remove obsolete template files
  • 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
  • 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
  • 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
  • ... and 379 more: https://git.openjdk.java.net/jdk/compare/89044200cd1eb8ab7747c8861320a291772b3dd3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 19, 2020
@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Oct 19, 2020

/integrate

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@azuev-java Since your change was applied there have been 390 commits pushed to the master branch:

  • dd032b7: 8254798: Deprecate for removal an empty finalize() methods in java.desktop module
  • 272bb5d: 8253455: Record Classes javax.lang.model changes
  • c17d585: 8246774: implement Record Classes as a standard feature in Java
  • 0b3e6c5: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails
  • ce1aac1: 8028707: javax/swing/JComboBox/6236162/bug6236162.java fails on azure
  • 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
  • e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
  • 402d01a: 8254795: Remove obsolete template files
  • 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
  • 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
  • ... and 380 more: https://git.openjdk.java.net/jdk/compare/89044200cd1eb8ab7747c8861320a291772b3dd3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 51a865d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@azuev-java azuev-java deleted the JDK-8254085 branch Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants