8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized

[wangweij]

Set output_token to empty. It is always accessed (even for a GSS_S_FAILURE) at

jdk/src/java.security.jgss/share/native/libj2gss/GSSLibStub.c

Line 1160 in cfa3f74

return getJavaBuffer(env, &outToken);

.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7163/head:pull/7163
$ git checkout pull/7163

Update a local copy of the PR:
$ git checkout pull/7163
$ git pull https://git.openjdk.java.net/jdk pull/7163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7163

View PR using the GUI difftool:
$ git pr show -t 7163

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7163.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e9d51ba4)

[valeriepeng]

Changes look good. Remember to add the noreg-xxx label. Thanks~

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

• 35ee0f3: 8258814: Compilation logging crashes for thread suspension / debugging tests
• 293fb46: 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms
• 2426d58: 8278472: Invalid value set to CANDIDATEFORM structure
• 02390c7: 8279282: [vectorapi] Matcher::supports_vector_comparison_unsigned is not needed on x86
• 3419ff7: 8277535: Remove redundant Stream.distinct()/sorted() steps
• d48279b: 8279009: CDS crashes when the source of an InstanceKlass is NULL
• 9636502: 8279008: G1: Calculate BOT threshold on-the-fly during Object Copy phase
• 0ea2b39: 8280363: Minor correction of ALPN specification in SSLParameters
• ec8b6ac: 8234682: The order of @param in the generated docs should match the method signature
• a4d2019: 8280178: Remove os:: API's that just call system API's
• ... and 48 more: https://git.openjdk.java.net/jdk/compare/98d96a770756ffe3e7f5e4b82120e9fb484cad9a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[openjdk]

Going to push as commit 6352c02.
Since your change was applied there have been 58 commits pushed to the master branch:

• 35ee0f3: 8258814: Compilation logging crashes for thread suspension / debugging tests
• 293fb46: 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms
• 2426d58: 8278472: Invalid value set to CANDIDATEFORM structure
• 02390c7: 8279282: [vectorapi] Matcher::supports_vector_comparison_unsigned is not needed on x86
• 3419ff7: 8277535: Remove redundant Stream.distinct()/sorted() steps
• d48279b: 8279009: CDS crashes when the source of an InstanceKlass is NULL
• 9636502: 8279008: G1: Calculate BOT threshold on-the-fly during Object Copy phase
• 0ea2b39: 8280363: Minor correction of ALPN specification in SSLParameters
• ec8b6ac: 8234682: The order of @param in the generated docs should match the method signature
• a4d2019: 8280178: Remove os:: API's that just call system API's
• ... and 48 more: https://git.openjdk.java.net/jdk/compare/98d96a770756ffe3e7f5e4b82120e9fb484cad9a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 6352c02.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.