Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8254955: x86: MethodHandlesAdapterBlob is too big #717

Closed
wants to merge 3 commits into from
Closed

8254955: x86: MethodHandlesAdapterBlob is too big #717

wants to merge 3 commits into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Oct 17, 2020 •
edited by openjdk bot

At some point JSR 292 was reworked to generate all but a small handful of interpreter stubs lazily, leaving the MethodHandlesAdapterBlob with a bit too much room to spare.

The remaining stubs use less than 1000 bytes of memory in product builds, and less than 3k in debug builds. This patch adjust the sizes accordingly.

Other platforms (except zero) seem like they could use a similar adjustment, but I don't have hardware available to check how big the interpreter stubs get on anything but x86 so I'll leave them untouched unless someone can run the numbers (java -XX:+UnlockDiagnosticVMOptions -XX:+VerifyMethodHandles -XX:+LogCompilation - grep the hotspot_log generated for MethodHandlesAdapterBlob or just blob since it's the first one)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254955: x86: MethodHandlesAdapterBlob is too big

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/717/head:pull/717
$ git checkout pull/717

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2020

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2020
@openjdk
Copy link

openjdk bot commented Oct 17, 2020

@cl4es The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 17, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2020 •
edited

Webrevs

neliasso
neliasso approved these changes Oct 18, 2020
View reviewed changes
Copy link

@neliasso neliasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Oct 18, 2020 •
edited

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254955: x86: MethodHandlesAdapterBlob is too big

Reviewed-by: neliasso, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 60f63ec: 8254796: Cleanup pervasive unnecessary parameter
  • 953e472: 8254967: com.sun.net.HttpsServer spins on TLS session close
  • 1da28de: 8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon
  • a0382cd: 8253235: JFR.dump does not respect maxage parameter
  • cb7701b: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid)
  • 4ffed32: 8254940: AArch64: Cleanup non-product thread members
  • cd66e0f: 8253877: gc/g1/TestGCLogMessages.java fails - missing "Evacuation failure" message
  • e76de18: 8223051: support loops with long (64b) trip counts
  • e9be2db: 8253453: SourceFileInfoTable should be allocated lazily
  • e10b538: 8243962: Various JVM TI tests time out using JFR on Windows
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/0b3e6c51bae47421d2fa3520b3eb6af22c668cc4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2020
vnkozlov
vnkozlov approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@cl4es
Copy link
Member Author

cl4es commented Oct 19, 2020

@neliasso @vnkozlov - thanks!

/integrate

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@cl4es Since your change was applied there have been 22 commits pushed to the master branch:

  • 0b51016: 8253660: Need better error report when artifact resolution fails in AotCompiler.java
  • 52cb329: 8254862: lldb in devkit doesn't work
  • 60f63ec: 8254796: Cleanup pervasive unnecessary parameter
  • 953e472: 8254967: com.sun.net.HttpsServer spins on TLS session close
  • 1da28de: 8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon
  • a0382cd: 8253235: JFR.dump does not respect maxage parameter
  • cb7701b: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid)
  • 4ffed32: 8254940: AArch64: Cleanup non-product thread members
  • cd66e0f: 8253877: gc/g1/TestGCLogMessages.java fails - missing "Evacuation failure" message
  • e76de18: 8223051: support loops with long (64b) trip counts
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/0b3e6c51bae47421d2fa3520b3eb6af22c668cc4...master

Your commit was automatically rebased without conflicts.

Pushed as commit e2e11d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnkozlov vnkozlov vnkozlov approved these changes

@neliasso neliasso neliasso approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
3 participants
@cl4es @vnkozlov @neliasso