8280414: Memory leak in DefaultProxySelector

[djelinski]

We were leaking the list returned by createProxyList. Verified that the leak is no longer present with this patch. Also removed a few unused variables.

Reported by clang-tidy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8280414: Memory leak in DefaultProxySelector

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7172/head:pull/7172
$ git checkout pull/7172

Update a local copy of the PR:
$ git checkout pull/7172
$ git pull https://git.openjdk.java.net/jdk pull/7172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7172

View PR using the GUI difftool:
$ git pr show -t 7172

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7172.diff

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0f6255e8)

[dfuch]

Look reasonable to me. Did you run tier1 - tier2 and tested locally?

[djelinski]

Tested locally. Returned values look correct, and the leak is removed. I also run jdk_net test suite, all green.

[djelinski]

tier1 and tier2 also passed.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280414: Memory leak in DefaultProxySelector

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 6287ae3: 8277531: Print actual default stacksize on Windows thread logging
• ab2c8d3: 8280393: Promote use of HtmlTree factory methods
• 47b1c51: 8277120: Use Optional.isEmpty instead of !Optional.isPresent in java.net.http
• 19f8779: 8278784: C2: Refactor PhaseIdealLoop::remix_address_expressions() so it operates on longs
• 6352c02: 8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized
• 35ee0f3: 8258814: Compilation logging crashes for thread suspension / debugging tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[djelinski]

Thanks for reviewing!

/integrate

[openjdk]

@djelinski
Your change (at version 0f6255e) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit fe77250.
Since your change was applied there have been 46 commits pushed to the master branch:

• 496baad: 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range
• 4503d04: 8280375: G1: Tighten mem region limit in G1RebuildRemSetHeapRegionClosure
• 36fbec7: 8280241: (aio) AsynchronousSocketChannel init fails in IPv6 only Windows env
• 28796cb: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC
• c43ce85: 8278302: [s390] Implement fast-path for ASCII-compatible CharsetEncoders
• 1b14157: 8280274: Guard printing code of Compile::print_method in PRODUCT
• 2155afe: 8280503: Use allStatic.hpp instead of allocation.hpp where possible
• 295b263: 8279241: G1 Full GC does not always slide memory to bottom addresses
• b327746: 8280384: Parallel: Remove VMThread specific ParCompactionManager
• 5380472: 8280470: Confusing instanceof check in HijrahChronology.range
• ... and 36 more: https://git.openjdk.java.net/jdk/compare/293fb46f7cd28f2a08055e3eb8ec9459d64e9688...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @djelinski Pushed as commit fe77250.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.