8214733: runtime/8176717/TestInheritFD.java timed out

[hseigel]

Please review this small change to fix TestInheritFD.java. The logs in the JBS bug indicate that the test probably timed out waiting for the lsof command to finish. This fix adds the -a and +d

options to the lsof command to limit its scope. The +d option tells lsof to only look in the specified directory for open files. The -a option combines the -p and the +d option. (An alternative fix would be to use the -b option.)

The fix was tested by running the test 1000 times on Linux x64 and Mac OS aarch64. The fix was also sanity tested on Linux aarch64, Mac OS x64, and windows.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8214733: runtime/8176717/TestInheritFD.java timed out

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer) ⚠️ Review applies to db0325d
• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to db0325d
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7179/head:pull/7179
$ git checkout pull/7179

Update a local copy of the PR:
$ git checkout pull/7179
$ git pull https://git.openjdk.java.net/jdk pull/7179/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7179

View PR using the GUI difftool:
$ git pr show -t 7179

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7179.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dc7c3b3c)
• 00: Full (db0325d0)

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8214733: runtime/8176717/TestInheritFD.java timed out

Reviewed-by: lmesnik, coleenp, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• c1e4f3d: 8279397: Update --release 18 symbol information for JDK 18 build 32
• 2920ce5: 8278036: Saving rscratch1 is optional in MacroAssembler::verify_heapbase
• 6287ae3: 8277531: Print actual default stacksize on Windows thread logging

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Nice.

[dcubed-ojdk]

Thumbs up. Minor request for a comment.

[dcubed-ojdk]

Thanks for adding the comment.

Since this failure mode reproduces on my Ubuntu 20.04 machine, I'll
keep my eyes open after you integrate.

[hseigel]

Thanks Leonid, Coleen, and Dan for the reviews!

/integrate

[openjdk]

Going to push as commit 4501ddd.
Since your change was applied there have been 12 commits pushed to the master branch:

• afd2805: 8279534: Consolidate and remove oopDesc::klass_gap methods
• f05ff99: 8280174: Possible NPE in Thread.dispatchUncaughtException
• 7a0a6c9: 8274751: Drag And Drop hangs on Windows
• 0567a84: 8280457: Duplicate implementation of dprecision_rounding and dstore_rounding
• d156911: 8280459: Suspicious integer division in Hashtable.readHashtable
• 9bf6ffa: 8279124: VM does not handle SIGQUIT during initialization
• 30cd47d: 8280499: runtime/cds/appcds/TestDumpClassListSource.java fails on platforms without AppCDS custom class loaders support
• 54c9de2: 8275918: Remove unused local variables in java.base security code
• b9ae779: 8279675: CDS cannot handle non-existent JAR file in bootclassapth
• c1e4f3d: 8279397: Update --release 18 symbol information for JDK 18 build 32
• ... and 2 more: https://git.openjdk.java.net/jdk/compare/ab2c8d3c9baf1080f436287785e4e02fd79953a7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@hseigel Pushed as commit 4501ddd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.