8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC #7181

djelinski · 2022-01-21T16:51:20Z

Fix RFC compliance.
Tier1 and tier2 passed.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC

Reviewers

Daniel Fuchs (@dfuch - Reviewer) ⚠️ Review applies to 86d6d6d
Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7181/head:pull/7181
$ git checkout pull/7181

Update a local copy of the PR:
$ git checkout pull/7181
$ git pull https://git.openjdk.java.net/jdk pull/7181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7181

View PR using the GUI difftool:
$ git pr show -t 7181

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7181.diff

bridgekeeper · 2022-01-21T16:52:08Z

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-01-21T16:53:47Z

@djelinski The following label will be automatically applied to this pull request:

net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-01-21T16:57:07Z

Webrevs

dfuch · 2022-01-21T17:52:46Z

Could you update the copyright years and add 8163921 to the @bug tag in the test?

dfuch

LGTM. @Michael-Mc-Mahon what's your take?

openjdk · 2022-01-24T12:01:27Z

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC

Reviewed-by: dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

2155afe: 8280503: Use allStatic.hpp instead of allocation.hpp where possible
295b263: 8279241: G1 Full GC does not always slide memory to bottom addresses
b327746: 8280384: Parallel: Remove VMThread specific ParCompactionManager
5380472: 8280470: Confusing instanceof check in HijrahChronology.range
a59d717: 8280289: Enhance debug pp() command with NMT info
f35df5b: 8280422: thread_from_jni_environment can never return NULL
e307655: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match
52ddbe2: Merge
ead9fec: 8280441: Missing "classpath exception" in several files from jdk.httpserver
7d2ef9d: 8279179: Update nroff pages in JDK 18 before RC
... and 30 more: https://git.openjdk.java.net/jdk/compare/293fb46f7cd28f2a08055e3eb8ec9459d64e9688...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @Michael-Mc-Mahon) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Michael-Mc-Mahon · 2022-01-24T14:38:02Z

src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

@@ -289,7 +289,7 @@ private static String getNetProperty(String name) {

    static final String httpVersion = "HTTP/1.1";
    static final String acceptString =
-        "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2";
+        "text/html, image/gif, image/jpeg, */*; q=0.2";



It looks syntactically correct now, but I wonder about the actual semantics, and whether it makes any sense to be asking for 80% reduction in quality of other media types.

Should we just have static final String acceptString = "*/*";

yeah, that's a sensible default. curl is using that today. I'll adjust.

Michael-Mc-Mahon

LGTM

djelinski · 2022-01-25T09:54:24Z

/integrate

openjdk · 2022-01-25T09:55:32Z

@djelinski
Your change (at version b9683b3) is now ready to be sponsored by a Committer.

Michael-Mc-Mahon · 2022-01-25T11:09:25Z

/sponsor

openjdk · 2022-01-25T11:11:00Z

Going to push as commit 28796cb.
Since your change was applied there have been 42 commits pushed to the master branch:

c43ce85: 8278302: [s390] Implement fast-path for ASCII-compatible CharsetEncoders
1b14157: 8280274: Guard printing code of Compile::print_method in PRODUCT
2155afe: 8280503: Use allStatic.hpp instead of allocation.hpp where possible
295b263: 8279241: G1 Full GC does not always slide memory to bottom addresses
b327746: 8280384: Parallel: Remove VMThread specific ParCompactionManager
5380472: 8280470: Confusing instanceof check in HijrahChronology.range
a59d717: 8280289: Enhance debug pp() command with NMT info
f35df5b: 8280422: thread_from_jni_environment can never return NULL
e307655: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match
52ddbe2: Merge
... and 32 more: https://git.openjdk.java.net/jdk/compare/293fb46f7cd28f2a08055e3eb8ec9459d64e9688...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-01-25T11:11:17Z

@Michael-Mc-Mahon @djelinski Pushed as commit 28796cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Fix default Accept header

be017d1

openjdk bot added the rfr Pull request is ready for review label Jan 21, 2022

openjdk bot added the net net-dev@openjdk.org label Jan 21, 2022

Update copyright year

86d6d6d

dfuch approved these changes Jan 24, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 24, 2022

Michael-Mc-Mahon reviewed Jan 24, 2022

View reviewed changes

Update accept header to */*

b9683b3

Michael-Mc-Mahon approved these changes Jan 24, 2022

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 25, 2022

openjdk bot added the integrated Pull request has been integrated label Jan 25, 2022

openjdk bot closed this Jan 25, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 25, 2022

djelinski deleted the fix-accept-header branch May 10, 2022 06:31

basil mentioned this pull request Dec 10, 2022

Try JDK 19 jenkinsci/bom#1637

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC #7181

8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC #7181

djelinski commented Jan 21, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 21, 2022

openjdk bot commented Jan 21, 2022

mlbridge bot commented Jan 21, 2022 •

edited

Loading

dfuch commented Jan 21, 2022

dfuch left a comment

openjdk bot commented Jan 24, 2022 •

edited

Loading

Michael-Mc-Mahon Jan 24, 2022

Michael-Mc-Mahon Jan 24, 2022

djelinski Jan 24, 2022

Michael-Mc-Mahon left a comment

djelinski commented Jan 25, 2022

openjdk bot commented Jan 25, 2022

Michael-Mc-Mahon commented Jan 25, 2022

openjdk bot commented Jan 25, 2022

openjdk bot commented Jan 25, 2022

8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC #7181

8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC #7181

Conversation

djelinski commented Jan 21, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jan 21, 2022

openjdk bot commented Jan 21, 2022

mlbridge bot commented Jan 21, 2022 • edited Loading

Webrevs

dfuch commented Jan 21, 2022

dfuch left a comment

Choose a reason for hiding this comment

openjdk bot commented Jan 24, 2022 • edited Loading

Michael-Mc-Mahon Jan 24, 2022

Choose a reason for hiding this comment

Michael-Mc-Mahon Jan 24, 2022

Choose a reason for hiding this comment

djelinski Jan 24, 2022

Choose a reason for hiding this comment

Michael-Mc-Mahon left a comment

Choose a reason for hiding this comment

djelinski commented Jan 25, 2022

openjdk bot commented Jan 25, 2022

Michael-Mc-Mahon commented Jan 25, 2022

openjdk bot commented Jan 25, 2022

openjdk bot commented Jan 25, 2022

djelinski commented Jan 21, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Jan 21, 2022 •

edited

Loading

openjdk bot commented Jan 24, 2022 •

edited

Loading