8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder

[mrserb]

In jdk 9 we started to sort the list of methods for each class for two reasons:

1. We had a number of bugs which state that our JavaBeans randomly does not work, examples: JDK-6807471[1] , JDK-6788525[2], the reason was that the order of methods from Class.getMethods() is not specified.
2. We tried to sort methods so the more specific returns types come first, this was done because our logic for selecting the correct method did not work properly.

The second issue above was fixed by the separate change JDK-8196373 so now we only need to sort the list of methods in any order and do not care about return types.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7190/head:pull/7190
$ git checkout pull/7190

Update a local copy of the PR:
$ git checkout pull/7190
$ git pull https://git.openjdk.java.net/jdk pull/7190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7190

View PR using the GUI difftool:
$ git pr show -t 7190

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7190.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (85451833)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 169 new commits pushed to the master branch:

• f7814c1: 8139173: [macosx] JInternalFrame shadow is not properly drawn
• 77b0240: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
• 42e272e: 8281289: Improve with List.copyOf
• 48523b0: 8281049: man page update for jstatd Security Manager dependency removal
• 8e4ef81: 8280767: -XX:ArchiveClassesAtExit does not archive BoundMethodHandle$Species classes
• f5d6fdd: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang
• d4b99bc: 8281120: G1: Rename G1BlockOffsetTablePart::alloc_block to update_for_block
• 66b2c3b: 8280948: [TESTBUG] Write a regression test for JDK-4659800
• 7207f2a: Merge
• 01f93dd: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344
• ... and 159 more: https://git.openjdk.java.net/jdk/compare/54c9de26aba24ff5496f97dd6cb95075ab6b9777...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

Going to push as commit 2f46af0.
Since your change was applied there have been 194 commits pushed to the master branch:

• fb17a8e: 8278947: Support for array constants in constant table
• d658d94: 8280828: Improve invariants in NonblockingQueue::append
• 5fb56db: 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java
• 92f4f40: 8281104: jar --create should create missing parent directories
• 7f19c70: 8281061: [s390] JFR runs into assertions while validating interpreter frames
• 380378c: 8281400: Remove unused wcslen() function
• 83d6745: 8281450: Remove unnecessary operator new and delete from ObjectMonitor
• f5d8ceb: 8281296: Create a regression test for JDK-4515999
• 861f279: 8280917: Simplify G1ConcurrentRefineThread activation
• f2a9627: 8279329: Remove hardcoded IPv4 available policy on Windows
• ... and 184 more: https://git.openjdk.java.net/jdk/compare/54c9de26aba24ff5496f97dd6cb95075ab6b9777...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 2f46af0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.