Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264743: Add forRemoval for deprecated classes and method in javax/swing/plaf/basic #7194

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 24, 2022

Few methods and classes were deprecated in JDK-8049700 where it was decided to add forRemoval in jdk19.
Added "forRemoval" to start the process of removing in near future jdk release.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8264743: Add forRemoval for deprecated classes and method in javax/swing/plaf/basic
  • JDK-8280846: Add forRemoval to deprecated classes and method in javax/swing/plaf/basic (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7194/head:pull/7194
$ git checkout pull/7194

Update a local copy of the PR:
$ git checkout pull/7194
$ git pull https://git.openjdk.java.net/jdk pull/7194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7194

View PR using the GUI difftool:
$ git pr show -t 7194

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7194.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 24, 2022
@openjdk
Copy link

openjdk bot commented Jan 24, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2022

Webrevs

@kevinrushforth
Copy link
Member

This needs a CSR. Please issue the /csr command, and then create a CSR in JBS.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jan 28, 2022
@prsadhuk
Copy link
Contributor Author

CSR added .JDK-8280846. Please review

@prrace
Copy link
Contributor

prrace commented Feb 6, 2022

"where it was decided to add forRemoval "
The actual sequence was that the previous fix proposed for Removal but even a cursory search found that
external L&Fs uses these
What was decided was to not do forRemoval then and it was suggested it could be a follow-up bug for a later release, as proposed here. But I don't see sign we've tried to engage with the maintainers of those L&Fs.

Because Swing is so widely used I suspect what was found is not all of i and forRemoval in Swing has a high probability of breaking some apps.

So we can do this now but we should not remove until after the next LTS which is JDK 12. So JDK 22.
And in the interim I strongly suggest some outreach to any L&Fs that might be broken,

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Feb 8, 2022
@openjdk
Copy link

openjdk bot commented Feb 8, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264743: Add forRemoval for deprecated classes and method in javax/swing/plaf/basic

Reviewed-by: trebari, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 419 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 8, 2022
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

Going to push as commit b4900b1.
Since your change was applied there have been 526 commits pushed to the master branch:

  • c0275e1: 8203290: [AIX] Check functionality of JDK-8199712 (Flight Recorder)
  • 1864481: 8279969: NULL return from map_bitmap_region() needs to be checked
  • 1eec16b: 8281803: AArch64: Optimize masked vector NOT/AND_NOT for SVE
  • cd234f5: 8282007: Assorted enhancements to jpackage testing framework
  • b6e48e6: Merge
  • 0f2113c: 8280415: Remove EA from JDK 18 version string starting with Initial RC promotion B35 on February 10, 2022
  • 2be2a29: 8281713: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
  • 0b00ce1: 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH%
  • 5ec7898: 8281671: Class.getCanonicalName spec should explicitly cover array classes
  • 9ba0760: 8275345: RasterFormatException when drawing a tiled image made of non-writable rasters
  • ... and 516 more: https://git.openjdk.java.net/jdk/compare/62d03c283667c4122130ec9bbeec623e6a2840e5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 17, 2022
@openjdk openjdk bot closed this Feb 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@prsadhuk Pushed as commit b4900b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8264743 branch February 17, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants