Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225790: Two NestedDialogs tests fail on Ubuntu #721

Closed
wants to merge 1 commit into from

Conversation

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Oct 17, 2020

Two NestedDialog tests are failing on Ubuntu 20.04 intermittently. I am able to reproduce the issue locally also sometime.

Tests are creating a frame and then create multiple dialogs. These tests are using classes VisibilityValidator and Waypoint (present in test/jdk/java/awt/regtesthelpers) for doing basic operations like waiting for a Frame/Dialog to become visible, doing a mouse click on a Frame/Window. Also, the test is not using Robot waitForIdle properly. so making the test less stable.

I have removed the lot of unnecessary code from the tests. Also, I have added proper AutoDelay on Robot and used waitForIdel properly. I have also removed the class VisibilityValidator and Waypoint. These classes were added with in test/jdk/java/awt/regtesthelpers when these tests were added. I don't see any use of these classes. No other test is using these classes at all and there is too much code in these classes.

I have run the multiple iterations of the test on mach5, it passes successfully. I have also run a full job to make confirm VisibilityValidator and Waypoint are not being used anywhere else.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/721/head:pull/721
$ git checkout pull/721

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 17, 2020

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 17, 2020

@pankaj-bansal The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the awt label Oct 17, 2020
@pankaj-bansal pankaj-bansal marked this pull request as ready for review Oct 17, 2020
@openjdk openjdk bot added the rfr label Oct 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 17, 2020

Webrevs

Loading

mrserb
mrserb approved these changes Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225790: Two NestedDialogs tests fail on Ubuntu

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • dd032b7: 8254798: Deprecate for removal an empty finalize() methods in java.desktop module
  • 272bb5d: 8253455: Record Classes javax.lang.model changes
  • c17d585: 8246774: implement Record Classes as a standard feature in Java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 19, 2020
@pankaj-bansal
Copy link
Author

@pankaj-bansal pankaj-bansal commented Oct 20, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@pankaj-bansal Since your change was applied there have been 42 commits pushed to the master branch:

  • 017d151: 8254842: [JVMCI] copy thread name when attaching libgraal thread to HotSpot
  • 5d1397f: 8254282: Add Linux x86_32 builds to submit workflow
  • 7ba6a6b: 8251158: Implementation of JEP 387: Elastic Metaspace
  • 5fedfa7: 8251271: C2: Compile::_for_igvn list is corrupted after RenumberLiveNodes
  • 98ec4a6: 8254805: compiler/debug/TestStressCM.java is still failing
  • 355f44d: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"
  • 0a75b37: 8254776: Remove unimplemented LowMemoryDetector::check_memory_usage
  • b65dcfa: 8197981: Missing return statement in __sync_val_compare_and_swap_8
  • 5b51085: 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes
  • c87cdf7: 8254029: ObjectMonitor cleanup/minor bug-fix changes extracted from JDK-8253064
  • ... and 32 more: https://git.openjdk.java.net/jdk/compare/0b3e6c51bae47421d2fa3520b3eb6af22c668cc4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 21e67e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@pankaj-bansal pankaj-bansal deleted the JDK-8225790 branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants