-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8225790: Two NestedDialogs tests fail on Ubuntu #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into |
@pankaj-bansal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@pankaj-bansal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@pankaj-bansal Since your change was applied there have been 42 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 21e67e5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Two NestedDialog tests are failing on Ubuntu 20.04 intermittently. I am able to reproduce the issue locally also sometime.
Tests are creating a frame and then create multiple dialogs. These tests are using classes VisibilityValidator and Waypoint (present in test/jdk/java/awt/regtesthelpers) for doing basic operations like waiting for a Frame/Dialog to become visible, doing a mouse click on a Frame/Window. Also, the test is not using Robot waitForIdle properly. so making the test less stable.
I have removed the lot of unnecessary code from the tests. Also, I have added proper AutoDelay on Robot and used waitForIdel properly. I have also removed the class VisibilityValidator and Waypoint. These classes were added with in test/jdk/java/awt/regtesthelpers when these tests were added. I don't see any use of these classes. No other test is using these classes at all and there is too much code in these classes.
I have run the multiple iterations of the test on mach5, it passes successfully. I have also run a full job to make confirm VisibilityValidator and Waypoint are not being used anywhere else.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/721/head:pull/721
$ git checkout pull/721