-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor #7215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back rrich! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for cleaning it up!
Feel free to remove the extra whitespace from the StubCodeGenerator
constructor new MacroAssembler(code )
(optional).
@reinrich This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 76 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks Martin!
I noticed it as well. You've encouraged me to actually remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There is nothing more to say for me after Martin found the last extra whitespace.
Thanks Lutz! |
/integrate |
Going to push as commit c936e70.
Your commit was automatically rebased without conflicts. |
This cleanup removes a redundant allocation from the StubGenerator constructor. The base class' constructor does the very same.
The fix passed our CI testing.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7215/head:pull/7215
$ git checkout pull/7215
Update a local copy of the PR:
$ git checkout pull/7215
$ git pull https://git.openjdk.java.net/jdk pull/7215/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7215
View PR using the GUI difftool:
$ git pr show -t 7215
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7215.diff