8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor

[reinrich]

This cleanup removes a redundant allocation from the StubGenerator constructor. The base class' constructor does the very same.

The fix passed our CI testing.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to dd330af
• Lutz Schmidt (@RealLucy - Reviewer) ⚠️ Review applies to dd330af

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7215/head:pull/7215
$ git checkout pull/7215

Update a local copy of the PR:
$ git checkout pull/7215
$ git pull https://git.openjdk.java.net/jdk pull/7215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7215

View PR using the GUI difftool:
$ git pr show -t 7215

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7215.diff

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (658104ed)
• 01: Full - Incremental (dd330af6)
• 00: Full (f0218ce5)

[TheRealMDoerr]

Looks good! Thanks for cleaning it up!
Feel free to remove the extra whitespace from the StubCodeGenerator constructor new MacroAssembler(code ) (optional).

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor

Reviewed-by: mdoerr, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 76 new commits pushed to the master branch:

• 16ec47d: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
• de3113b: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
• 0e70d45: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
• 1ea0146: 8281007: Test jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java fails after JDK-8280738
• 9c0104b: 8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack
• 4dbebb6: 8280534: Enable compile-time doclint reference checking
• 4191b2b: 8275337: C1: assert(false) failed: live_in set of first block must be empty
• 96d0df7: 8272984: javadoc support for reproducible builds
• ee3be0b: 8280488: doclint reference checks withstand warning suppression
• 74921e8: 8280738: Minor cleanup for HtmlStyle
• ... and 66 more: https://git.openjdk.java.net/jdk/compare/496baada1021eecae03e737afe838ad6d383cba9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[reinrich]

Looks good! Thanks for cleaning it up!

Thanks Martin!

Feel free to remove the extra whitespace from the StubCodeGenerator constructor new MacroAssembler(code ) (optional).

I noticed it as well. You've encouraged me to actually remove it.

[TheRealMDoerr]

Excellent!

[RealLucy]

Looks good to me!
There is nothing more to say for me after Martin found the last extra whitespace.

[reinrich]

Thanks Lutz!

[reinrich]

/integrate

[openjdk]

Going to push as commit c936e70.
Since your change was applied there have been 119 commits pushed to the master branch:

• 63e11cf: 8280970: Cleanup dead code in java.security.Provider
• e44dc63: 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack
• b6935df: 8251505: Use of types in compiler shared code should be consistent.
• 130cf46: 4750574: (se spec) Selector spec should clarify calculation of select return value
• cda9c30: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call
• 86c24b3: 8240908: RetransformClass does not know about MethodParameters attribute
• 1f92660: 8281057: Fix doc references to overriding in JLS
• 010965c: 8281023: NMT integration into pp debug command does not work
• 63a00a0: 8272777: Clean up remaining AccessController warnings in test library
• 5ab22e8: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
• ... and 109 more: https://git.openjdk.java.net/jdk/compare/496baada1021eecae03e737afe838ad6d383cba9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit c936e70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.