New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8280703 CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption #7230
Conversation
👋 Welcome back overheadhunter! A progress list of the required criteria for merging this PR into |
@overheadhunter The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright date will need to be updated from 2021 to 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff passed tier1 and crypto tests. Looks good to me
@overheadhunter This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ascarpino) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@overheadhunter |
/sponsor |
Going to push as commit 409382b.
Your commit was automatically rebased without conflicts. |
@ascarpino @overheadhunter Pushed as commit 409382b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Related to #411, however it turns out that for unpadded ciphers, there is no need to allocate
internalOutput
, ifoutput
provides sufficient capacity.For padded ciphers, only the unpadded cleartext is expected to be copied to the output buffer. In this case, there is no way around the temporary buffer (without major changes).
While a small change, please review with care, as I might be missing some security-relevant side effect (such as: don't copy cleartext to output buffer before validating the a tag - just as an example, even if there is no authentication involved in this method).
I have some test failures in Tier 1 tests, but these seem to be unrelated. Tests for
com.sun.crypto
andjavax.crypto
run fine:Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7230/head:pull/7230
$ git checkout pull/7230
Update a local copy of the PR:
$ git checkout pull/7230
$ git pull https://git.openjdk.java.net/jdk pull/7230/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7230
View PR using the GUI difftool:
$ git pr show -t 7230
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7230.diff