Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280783: Parallel: Refactor PSCardTable::scavenge_contents_parallel #7243

Closed

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 27, 2022

A new version of PSCardTable::scavenge_contents_parallel with cleaner structure and most of the existing behavior. The deviation is so large that the diff is not very sensible; reading the new code directly is probably easier.

This PR doesn't take advantage of precise card marking, just like the existing code. IOW, the code assumes all cards are imprecisely marked. Optimizations like utilizing precise card marking will be investigated/attempted in another ticket/PR.

Test: Tier1-6


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280783: Parallel: Refactor PSCardTable::scavenge_contents_parallel

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7243/head:pull/7243
$ git checkout pull/7243

Update a local copy of the PR:
$ git checkout pull/7243
$ git pull https://git.openjdk.java.net/jdk pull/7243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7243

View PR using the GUI difftool:
$ git pr show -t 7243

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7243.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 27, 2022
@openjdk
Copy link

openjdk bot commented Jan 27, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2022

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jan 27, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280783: Parallel: Refactor PSCardTable::scavenge_contents_parallel

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 144 new commits pushed to the master branch:

  • c5c8c06: 8279822: CI: Constant pool entries in error state are not supported
  • f823bed: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2
  • 8b384b9: 8281470: tools/jar/CreateMissingParentDirectories.java fails with "Should have failed creating jar file"
  • bb2e10c: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info
  • 69e390a: 8262721: Add Tests to verify single iteration loops are properly optimized
  • f092bab: 8281195: Mistakenly used logging causes significant overhead in interpreter
  • f924e50: 8281440: AWT: Conversion from string literal loses const qualifier
  • 072e7b4: 8272807: Permit use of memory concurrent with pretouch
  • cb2f8ca: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working
  • fc77217: 8281168: Micro-optimize VarForm.getMemberName for interpreter
  • ... and 134 more: https://git.openjdk.java.net/jdk/compare/c2ee1b33c37e6f2848dc8b3e5417b93b1dac1112...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2022
Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 14, 2022

Going to push as commit 2597206.
Since your change was applied there have been 184 commits pushed to the master branch:

  • 2632d40: 8281637: Remove unused VerifyOption_G1UseNextMarking
  • 46f5229: 8281539: IGV: schedule approximation computes immediate dominators wrongly
  • 1ef45c5: 8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination
  • 483d4b9: 8281505: Add CompileCommand PrintIdealPhase
  • adbe066: 8239927: Product variable PrefetchFieldsAhead is unused and should be removed
  • eff5daf: 8274939: Incorrect size of the pixel storage is used by the robot on macOS
  • 8acfbc2: 8281675: VMDeprecatedOptions test fails after JDK-8278423
  • 67077a0: 8278423: ExtendedDTraceProbes should be deprecated
  • 58dae60: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • aa918a6: 8281033: Improve ImageCheckboxTest to test all available LaF
  • ... and 174 more: https://git.openjdk.java.net/jdk/compare/c2ee1b33c37e6f2848dc8b3e5417b93b1dac1112...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 14, 2022
@openjdk openjdk bot closed this Feb 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2022
@openjdk
Copy link

openjdk bot commented Feb 14, 2022

@albertnetymk Pushed as commit 2597206.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the scavenge_contents_parallel branch February 14, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants