Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280823: Remove NULL check in DumpTimeClassInfo::is_excluded #7249

Conversation

iklam
Copy link
Member

@iklam iklam commented Jan 27, 2022

Please review this trivial change. The NULL check is not needed anymore because the ``DumpTimeClassInfo::_klass` field is never set to NULL.

Passed Oracle IT tiers 1~4


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280823: Remove NULL check in DumpTimeClassInfo::is_excluded

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7249/head:pull/7249
$ git checkout pull/7249

Update a local copy of the PR:
$ git checkout pull/7249
$ git pull https://git.openjdk.java.net/jdk pull/7249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7249

View PR using the GUI difftool:
$ git pr show -t 7249

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7249.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2022

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 27, 2022
@openjdk
Copy link

openjdk bot commented Jan 27, 2022

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Jan 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2022

Webrevs

yminqi
yminqi approved these changes Jan 27, 2022
Copy link
Contributor

@yminqi yminqi left a comment

LGTM.

@openjdk
Copy link

openjdk bot commented Jan 27, 2022

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280823: Remove NULL check in DumpTimeClassInfo::is_excluded

Reviewed-by: minqi, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 094db1a: 8277948: AArch64: Print the correct native stack if -XX:+PreserveFramePointer when crash
  • 7857405: 8280744: Allow SuppressWarnings to be used in all declaration contexts
  • 40a2ce2: 8270476: Make floating-point test infrastructure more lambda and method reference friendly
  • 6d242e4: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy
  • ece89c6: 8280366: (fs) Restore Files.createTempFile javadoc
  • b94ebaa: 8280686: Remove Compile::print_method_impl
  • a3a0dcd: 8280353: -XX:ArchiveClassesAtExit should print warning if base archive failed to load
  • cab5905: 8280583: Always build NMT
  • 7f68759: 8280719: G1: Remove outdated comment in RemoveSelfForwardPtrObjClosure::apply
  • 94380d0: 8278232: [macos] Wrong chars emitted when entering certain char-sequence of Indic language
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/c2ee1b33c37e6f2848dc8b3e5417b93b1dac1112...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 27, 2022
Copy link
Member

@calvinccheung calvinccheung left a comment

LGTM

yminqi
yminqi approved these changes Jan 28, 2022
@iklam
Copy link
Member Author

iklam commented Jan 28, 2022

Thanks @yminqi and @calvinccheung for the review
/integrate

@openjdk
Copy link

openjdk bot commented Jan 28, 2022

Going to push as commit a1d1e47.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 094db1a: 8277948: AArch64: Print the correct native stack if -XX:+PreserveFramePointer when crash
  • 7857405: 8280744: Allow SuppressWarnings to be used in all declaration contexts
  • 40a2ce2: 8270476: Make floating-point test infrastructure more lambda and method reference friendly
  • 6d242e4: 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy
  • ece89c6: 8280366: (fs) Restore Files.createTempFile javadoc
  • b94ebaa: 8280686: Remove Compile::print_method_impl
  • a3a0dcd: 8280353: -XX:ArchiveClassesAtExit should print warning if base archive failed to load
  • cab5905: 8280583: Always build NMT
  • 7f68759: 8280719: G1: Remove outdated comment in RemoveSelfForwardPtrObjClosure::apply
  • 94380d0: 8278232: [macos] Wrong chars emitted when entering certain char-sequence of Indic language
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/c2ee1b33c37e6f2848dc8b3e5417b93b1dac1112...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 28, 2022
@openjdk openjdk bot closed this Jan 28, 2022
@openjdk openjdk bot removed ready rfr labels Jan 28, 2022
@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@iklam Pushed as commit a1d1e47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
4 participants