New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280823: Remove NULL check in DumpTimeClassInfo::is_excluded #7249
8280823: Remove NULL check in DumpTimeClassInfo::is_excluded #7249
Conversation
|
@iklam This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks @yminqi and @calvinccheung for the review |
Going to push as commit a1d1e47.
Your commit was automatically rebased without conflicts. |
Please review this trivial change. The NULL check is not needed anymore because the ``DumpTimeClassInfo::_klass` field is never set to NULL.
Passed Oracle IT tiers 1~4
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7249/head:pull/7249
$ git checkout pull/7249
Update a local copy of the PR:
$ git checkout pull/7249
$ git pull https://git.openjdk.java.net/jdk pull/7249/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7249
View PR using the GUI difftool:
$ git pr show -t 7249
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7249.diff