Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8228988: AnnotationParser throws NullPointerException on incompatible member type #725

Closed
wants to merge 1 commit into from

Conversation

raphw
Copy link
Member

@raphw raphw commented Oct 18, 2020

If an annotation member type is changed in an incompatible manner, the AnnotationParser currently throws a NullPointerException if:

  • An enumeration-typed member is changed to be an annotation type or a Class type.
  • An annotation type is changed to be a non-annotation type.

This patch creates AnnotationTypeMismatchExceptionProxy to give users a better error message and to delay the exception to the time where the annotation member is attempted to be accessed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux aarch64 Linux arm Linux ppc64le Linux s390x Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8228988: AnnotationParser throws NullPointerException on incompatible member type

Download

$ git fetch https://git.openjdk.java.net/jdk pull/725/head:pull/725
$ git checkout pull/725

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2020

👋 Welcome back winterhalter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2020
@openjdk
Copy link

openjdk bot commented Oct 18, 2020

@raphw The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 18, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2020

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2020

@raphw This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@raphw
Copy link
Member Author

raphw commented Nov 16, 2020

Commenting to avoid automatic closing.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2020

@raphw This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2021

@raphw This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!

@bridgekeeper bridgekeeper bot closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
1 participant