New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280543: Update the "java" and "jcmd" tool specification for CDS #7255
Conversation
|
/label add hotspot-runtime |
@iklam |
Webrevs
|
LGTM. The copyright in jcmd.1 needs updating.
Thanks, Harold
@iklam This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 38 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks @hseigel @calvinccheung @sspitsyn for the review. |
Going to push as commit 3916561.
Your commit was automatically rebased without conflicts. |
The discussion of CDS in the man pages need to be cleaned up and updated to match the latest functionalities and intended usage.
For java.md:
jcmd VM.cds static_dump|dynamic_dump
For jcmd.md:
For ease of reviewing, please see the pre-rendered HTML pages:
http://cr.openjdk.java.net/~iklam/jdk19/8280543-update-java-and-jcmd-manpage-for-cds2/specs/man/
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7255/head:pull/7255
$ git checkout pull/7255
Update a local copy of the PR:
$ git checkout pull/7255
$ git pull https://git.openjdk.java.net/jdk pull/7255/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7255
View PR using the GUI difftool:
$ git pr show -t 7255
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7255.diff