Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered #7257

Closed
wants to merge 2 commits into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Jan 28, 2022

When using -Xcomp, the liveness of some objects the test allocates is more precisely known, allowing the objects to be collected before the test expects. This became an issue in the loom repo because it has changes that result in a full GC when the codecache is swept. This is fixed by using statics to reference the objects. Also, if a GC does happen, this seems to get rid of the Survivor region, so the test was updated to no longer check for it.

I'm choosing to fix this in the jdk repo rather than the loom repo since it is a latent bug that theoretically could occur even without the loom changes, and also to help reduce the amount of changes to be reviewed when loom is integrated into jdk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7257/head:pull/7257
$ git checkout pull/7257

Update a local copy of the PR:
$ git checkout pull/7257
$ git pull https://git.openjdk.java.net/jdk pull/7257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7257

View PR using the GUI difftool:
$ git pr show -t 7257

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7257.diff

@plummercj
Copy link
Contributor Author

plummercj commented Jan 28, 2022

/label serviceability

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2022

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr serviceability labels Jan 28, 2022
@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 28, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered

Reviewed-by: alanb, amenkov, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 204 new commits pushed to the master branch:

  • c5a8612: 8280458: G1: Remove G1BlockOffsetTablePart::_next_offset_threshold
  • 86debf4: 8280932: G1: Rename HeapRegionRemSet::_code_roots accessors
  • d37fb1d: 8280870: Parallel: Simplify CLD roots claim in Full GC cycle
  • 18a7dc8: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking
  • 16ec47d: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
  • de3113b: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
  • 0e70d45: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • 1ea0146: 8281007: Test jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java fails after JDK-8280738
  • 9c0104b: 8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack
  • 4dbebb6: 8280534: Enable compile-time doclint reference checking
  • ... and 194 more: https://git.openjdk.java.net/jdk/compare/46fd683820bb7149c0605a0ba03f59e76de69c16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 28, 2022
lmesnik
lmesnik approved these changes Feb 1, 2022
@plummercj
Copy link
Contributor Author

plummercj commented Feb 1, 2022

Thanks for the reviews Alex, Alan, and Leonid!

@plummercj
Copy link
Contributor Author

plummercj commented Feb 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

Going to push as commit 4532c3a.
Since your change was applied there have been 206 commits pushed to the master branch:

  • 5080e81: 8280770: serviceability/sa/ClhsdbThreadContext.java sometimes fails with 'Thread "SteadyStateThread"' missing from stdout/stderr
  • 1f6fcbe: 8278475: G1 dirty card refinement by Java threads may get unnecessarily paused
  • c5a8612: 8280458: G1: Remove G1BlockOffsetTablePart::_next_offset_threshold
  • 86debf4: 8280932: G1: Rename HeapRegionRemSet::_code_roots accessors
  • d37fb1d: 8280870: Parallel: Simplify CLD roots claim in Full GC cycle
  • 18a7dc8: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking
  • 16ec47d: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
  • de3113b: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
  • 0e70d45: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • 1ea0146: 8281007: Test jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java fails after JDK-8280738
  • ... and 196 more: https://git.openjdk.java.net/jdk/compare/46fd683820bb7149c0605a0ba03f59e76de69c16...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 1, 2022
@openjdk openjdk bot closed this Feb 1, 2022
@openjdk openjdk bot removed ready rfr labels Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@plummercj Pushed as commit 4532c3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8280554-g1_scanoops branch Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants