Skip to content

8254884: Make sure jvm does not crash with Arm SVE and Vector API #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

8254884: Make sure jvm does not crash with Arm SVE and Vector API #726

wants to merge 3 commits into from

Conversation

nsjian
Copy link

@nsjian nsjian commented Oct 19, 2020 •
edited by openjdk bot
Loading

Currently we have not implemented all Arm SVE code generation for Vector API specific nodes. To make sure hotspot does not crash with bad AD file (as NEON has implemented them), we simply add those OPs to unsupported op list.

This is the port and minor cleanup of JDK-8253211 in repo-panama: openjdk/panama-vector#7 with Op_VectorUnbox (not for codegen) and Op_VectorMaskWrapper (actually unused node. dead code?) removed from the unsupported op list and Op_VectorLoadConst added.

Test: tier1-3 on AArch64 and x86_64 as well as Vector API tests on AArch64 SVE.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254884: Make sure jvm does not crash with Arm SVE and Vector API

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/726/head:pull/726
$ git checkout pull/726

8254884: Make sure jvm does not crash with Arm SVE and Vector API
1e51f41 
===
Currently we have not implemented all Arm SVE code generation for
Vector API specific nodes. To make sure hotspot does not crash with bad
AD file (as NEON has implemented them), we simply add those OPs to
unsupported op list.

This is the port and minor cleanup of JDK-8253211 in repo-panama:
openjdk/panama-vector#7
with Op_VectorUnbox (not for codegen) and Op_VectorMaskWrapper (unused
code?) removed from the unsupported op list and Op_VectorLoadConst
added.

Test: tier1-3 on AArch64 and x86_64 as well as Vector API tests on
AArch64 SVE.
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2020

👋 Welcome back njian! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@nsjian The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 19, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2020 •
edited
Loading

Webrevs

Address review comments from Vladimir.
9bfa188 
Change-Id: Ia484dc59f41d265972f1253193d1d7d7cb032a12
iwanowww
iwanowww approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared code changes look good.

@openjdk
Copy link

openjdk bot commented Oct 19, 2020 •
edited
Loading

@nsjian This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254884: Make sure jvm does not crash with Arm SVE and Vector API

Reviewed-by: vlivanov, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 294e070: 8254998: C2: assert(!n->as_Loop()->is_transformed_long_loop()) failure with -XX:StressLongCountedLoop=1
  • 3ee0380: 8234393: [macos] printing ignores printer tray
  • 3f9c8a3: 8254966: Remove unused code from Matcher
  • 21e67e5: 8225790: Two NestedDialogs tests fail on Ubuntu
  • 017d151: 8254842: [JVMCI] copy thread name when attaching libgraal thread to HotSpot
  • 5d1397f: 8254282: Add Linux x86_32 builds to submit workflow
  • 7ba6a6b: 8251158: Implementation of JEP 387: Elastic Metaspace
  • 5fedfa7: 8251271: C2: Compile::_for_igvn list is corrupted after RenumberLiveNodes
  • 98ec4a6: 8254805: compiler/debug/TestStressCM.java is still failing
  • 355f44d: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/a1a3e9def7fee87e51fa6c71e870bc069cf759b5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2020
adinn
adinn approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotspot changes look good.

@nsjian
Copy link
Author

nsjian commented Oct 21, 2020

Thank you @iwanowww @adinn for the review. My local tests passed with updated patch.

@nsjian
Copy link
Author

nsjian commented Oct 21, 2020

/integrate

@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2020
@openjdk
Copy link

openjdk bot commented Oct 21, 2020

@nsjian Since your change was applied there have been 72 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 42a6ead.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nsjian nsjian mentioned this pull request Oct 22, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinn adinn adinn approved these changes

@iwanowww iwanowww iwanowww approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsjian @adinn @iwanowww