Skip to content

8280868: LineBodyHandlerTest.java creates and discards too many clients #7263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Jan 28, 2022

Please find enclosed a simple test fix for:
8280868: LineBodyHandlerTest.java creates and discards too many clients

The LineBodyHandlerTest.java creates and discards many clients (64).
The test has been observed failing intermittently on some systems (Windows 10) while trying to open the client's selector, apparently due to some connection limit.

It seems that using a single client reduces the occurrences in which the test fails.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280868: LineBodyHandlerTest.java creates and discards too many clients

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7263/head:pull/7263
$ git checkout pull/7263

Update a local copy of the PR:
$ git checkout pull/7263
$ git pull https://git.openjdk.java.net/jdk pull/7263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7263

View PR using the GUI difftool:
$ git pr show -t 7263

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7263.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2022

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 28, 2022
@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jan 28, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2022

Webrevs

Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280868: LineBodyHandlerTest.java creates and discards too many clients

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

  • 9d57853: 8281042: G1: Remove unused init_threshold in G1FullGCCompactionPoint
  • 87ab099: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism
  • ce71e8b: 8279917: Refactor subclassAudits in Thread to use ClassValue
  • 4ea6037: 8281035: Serial: Move RemoveForwardedPointerClosure to local scope
  • ae2504b: 8278254: Cleanup doclint warnings in java.desktop module
  • de826ba: 8280600: C2: assert(!had_error) failed: bad dominance
  • 4304a77: 8279535: C2: Dead code in PhaseIdealLoop::create_loop_nest after JDK-8276116
  • ab63834: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 48a32b5: 8280976: Incorrect encoding of avx512 vpsraq instruction with mask and constant shift.
  • 97af323: 8280842: Access violation in ciTypeFlow::profiled_count
  • ... and 75 more: https://git.openjdk.java.net/jdk/compare/f34f8d4d6a9b3e24a93a322b985c1413c27311cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 2, 2022
@dfuch
Copy link
Member Author

dfuch commented Feb 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

Going to push as commit 47800bf.
Since your change was applied there have been 85 commits pushed to the master branch:

  • 9d57853: 8281042: G1: Remove unused init_threshold in G1FullGCCompactionPoint
  • 87ab099: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism
  • ce71e8b: 8279917: Refactor subclassAudits in Thread to use ClassValue
  • 4ea6037: 8281035: Serial: Move RemoveForwardedPointerClosure to local scope
  • ae2504b: 8278254: Cleanup doclint warnings in java.desktop module
  • de826ba: 8280600: C2: assert(!had_error) failed: bad dominance
  • 4304a77: 8279535: C2: Dead code in PhaseIdealLoop::create_loop_nest after JDK-8276116
  • ab63834: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 48a32b5: 8280976: Incorrect encoding of avx512 vpsraq instruction with mask and constant shift.
  • 97af323: 8280842: Access violation in ciTypeFlow::profiled_count
  • ... and 75 more: https://git.openjdk.java.net/jdk/compare/f34f8d4d6a9b3e24a93a322b985c1413c27311cc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2022
@openjdk openjdk bot closed this Feb 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@dfuch Pushed as commit 47800bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants