JDK-8280941: os::print_memory_mappings() prints segment preceeding the inclusion range

[tstuefe]

os::print_memory_mappings() is a helpful little routine to print existing memory mappings within a given range. On Linux, it parses proc//maps. But it always prints a segment preceding the start address, e.g. here see the first line:

Range [7f92467a3000-7f92467a9000) contains: 7f924679f000-7f92467a3000 rw-p 00000000 00:00 0
7f92467a3000-7f92467a4000 rwxp 00000000 00:00 0
7f92467a4000-7f92467a5000 rw-p 00000000 00:00 0
7f92467a5000-7f92467a6000 rwxp 00000000 00:00 0
7f92467a6000-7f92467a7000 rw-p 00000000 00:00 0
7f92467a7000-7f92467a8000 rwxp 00000000 00:00 0
7f92467a8000-7f92467a9000 rw-p 00000000 00:00 0

and it should also precede the first line with a newline

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8280941: os::print_memory_mappings() prints segment preceeding the inclusion range

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Yumin Qi (@yminqi - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7289/head:pull/7289
$ git checkout pull/7289

Update a local copy of the PR:
$ git checkout pull/7289
$ git pull https://git.openjdk.java.net/jdk pull/7289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7289

View PR using the GUI difftool:
$ git pr show -t 7289

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7289.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f8ef7366)

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280941: os::print_memory_mappings() prints segment preceeding the inclusion range

Reviewed-by: stefank, minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 4532c3a: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered
• 5080e81: 8280770: serviceability/sa/ClhsdbThreadContext.java sometimes fails with 'Thread "SteadyStateThread"' missing from stdout/stderr
• 1f6fcbe: 8278475: G1 dirty card refinement by Java threads may get unnecessarily paused
• c5a8612: 8280458: G1: Remove G1BlockOffsetTablePart::_next_offset_threshold
• 86debf4: 8280932: G1: Rename HeapRegionRemSet::_code_roots accessors
• d37fb1d: 8280870: Parallel: Simplify CLD roots claim in Full GC cycle
• 18a7dc8: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking
• 16ec47d: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
• de3113b: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
• 0e70d45: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/be9f984caec32c3fe1deef30efe40fa115409ca0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[yminqi]

LGTM.

[tstuefe]

Thanks @stefank and @yminqi.

/integrate

[openjdk]

Going to push as commit d1cc5fd.
Since your change was applied there have been 27 commits pushed to the master branch:

• 4532c3a: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered
• 5080e81: 8280770: serviceability/sa/ClhsdbThreadContext.java sometimes fails with 'Thread "SteadyStateThread"' missing from stdout/stderr
• 1f6fcbe: 8278475: G1 dirty card refinement by Java threads may get unnecessarily paused
• c5a8612: 8280458: G1: Remove G1BlockOffsetTablePart::_next_offset_threshold
• 86debf4: 8280932: G1: Rename HeapRegionRemSet::_code_roots accessors
• d37fb1d: 8280870: Parallel: Simplify CLD roots claim in Full GC cycle
• 18a7dc8: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking
• 16ec47d: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
• de3113b: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
• 0e70d45: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/be9f984caec32c3fe1deef30efe40fa115409ca0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit d1cc5fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.