Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280976: Incorrect encoding of avx512 vpsraq instruction with mask and constant shift. #7291

Closed
wants to merge 1 commit into from

Conversation

jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Jan 31, 2022

  • Incorrect encoding fixed.
EVEX.512.66.0F.W1 72 /4 ib VPSRAQ zmm1 {k1}{z}, zmm2/m512/m64bcst, imm8 F V/V AVX512F Shift quadwords in zmm2/m512/m64bcst right by imm8 while shifting in sign bits using writemask k1.

Thanks,
Jatin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280976: Incorrect encoding of avx512 vpsraq instruction with mask and constant shift.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7291/head:pull/7291
$ git checkout pull/7291

Update a local copy of the PR:
$ git checkout pull/7291
$ git pull https://git.openjdk.java.net/jdk pull/7291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7291

View PR using the GUI difftool:
$ git pr show -t 7291

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7291.diff

@jatin-bhateja
Copy link
Member Author

jatin-bhateja commented Jan 31, 2022

/label add hotspot-compiler-dev

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2022

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr hotspot-compiler labels Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@jatin-bhateja
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 31, 2022

Webrevs

Copy link

@neliasso neliasso left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280976: Incorrect encoding of avx512 vpsraq instruction with mask and constant shift.

Reviewed-by: neliasso, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 85d839f: 8280601: ClhsdbThreadContext.java test is triggering codecache related asserts
  • 9ca7ff3: 8281082: Improve javadoc references to JOSS
  • c74b8f4: 8275914: SHA3: changing java implementation to help C2 create high-performance code
  • a18beb4: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs
  • fdd9ca7: 8280642: ObjectInputStream.readObject should throw InvalidClassException instead of IllegalAccessError
  • d95de5c: 8255495: Support CDS Archived Heap for uncompressed oops
  • bde2b37: 8279954: java/lang/StringBuffer(StringBuilder)/HugeCapacity.java intermittently fails
  • d1cc5fd: 8280941: os::print_memory_mappings() prints segment preceeding the inclusion range
  • 4532c3a: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered
  • 5080e81: 8280770: serviceability/sa/ClhsdbThreadContext.java sometimes fails with 'Thread "SteadyStateThread"' missing from stdout/stderr
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/be9f984caec32c3fe1deef30efe40fa115409ca0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 1, 2022
@jatin-bhateja
Copy link
Member Author

jatin-bhateja commented Feb 2, 2022

Thanks @neliasso , do I need another reviewer approval for this.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good.

@jatin-bhateja
Copy link
Member Author

jatin-bhateja commented Feb 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

Going to push as commit 48a32b5.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 97af323: 8280842: Access violation in ciTypeFlow::profiled_count
  • d32f99e: 8279219: [REDO] C2 crash when allocating array of size too large
  • 85d839f: 8280601: ClhsdbThreadContext.java test is triggering codecache related asserts
  • 9ca7ff3: 8281082: Improve javadoc references to JOSS
  • c74b8f4: 8275914: SHA3: changing java implementation to help C2 create high-performance code
  • a18beb4: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs
  • fdd9ca7: 8280642: ObjectInputStream.readObject should throw InvalidClassException instead of IllegalAccessError
  • d95de5c: 8255495: Support CDS Archived Heap for uncompressed oops
  • bde2b37: 8279954: java/lang/StringBuffer(StringBuilder)/HugeCapacity.java intermittently fails
  • d1cc5fd: 8280941: os::print_memory_mappings() prints segment preceeding the inclusion range
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/be9f984caec32c3fe1deef30efe40fa115409ca0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 2, 2022
@openjdk openjdk bot closed this Feb 2, 2022
@openjdk openjdk bot removed ready rfr labels Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@jatin-bhateja Pushed as commit 48a32b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jatin-bhateja jatin-bhateja deleted the JDK-8280976 branch Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants