New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix #7292
Conversation
…mant after JDK-8280550 fix
|
Webrevs
|
} | ||
|
||
@Override | ||
public long nextLong() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad indentation.
public static void nextDoublesWithRange(double origin, double bound) { | ||
RandomGenerator rg = new RandomGenerator() { | ||
@Override | ||
public double nextDouble() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all right modulo the copyright year.
@jddarcy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/integrate |
Going to push as commit 0e70d45.
Your commit was automatically rebased without conflicts. |
The original fix to JDK-8280550 contained a typo where r rather than bound was used as the first argument to nextAfter; this PR corrects that issue.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7292/head:pull/7292
$ git checkout pull/7292
Update a local copy of the PR:
$ git checkout pull/7292
$ git pull https://git.openjdk.java.net/jdk pull/7292/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7292
View PR using the GUI difftool:
$ git pr show -t 7292
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7292.diff