8281043: Intrinsify recursive ObjectMonitor locking for PPC64

[TheRealMDoerr]

PPC64 implementation of JDK-8277180.

java -Xms4g -Xmx4g -jar dacapo-9.12-bach.jar h2 -s huge -t 1 -n 1 --max-iterations=35 --variance=5 --verbose --converge

Before this patch (2 runs):
===== DaCapo 9.12 h2 PASSED in 309753 msec =====
===== DaCapo 9.12 h2 PASSED in 300755 msec =====

After:
===== DaCapo 9.12 h2 PASSED in 285144 msec =====
===== DaCapo 9.12 h2 PASSED in 288255 msec =====

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281043: Intrinsify recursive ObjectMonitor locking for PPC64

Reviewers

• Richard Reingruber (@reinrich - Reviewer)
• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7305/head:pull/7305
$ git checkout pull/7305

Update a local copy of the PR:
$ git checkout pull/7305
$ git pull https://git.openjdk.java.net/jdk pull/7305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7305

View PR using the GUI difftool:
$ git pr show -t 7305

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7305.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (88861201)
• 01: Full - Incremental (1eec2373)
• 00: Full (2428acce)

[reinrich]

Hi Martin,

the change looks good. Have you tested it with a quick micro benchmark?

The copyright needs to be updated.

Cheers, Richard.

[TheRealMDoerr]

Thanks for the review! Copyright updated and benchmark results added above.

[reinrich]

Looks good.

Thanks, Richard.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281043: Intrinsify recursive ObjectMonitor locking for PPC64

Reviewed-by: rrich, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 86c24b3: 8240908: RetransformClass does not know about MethodParameters attribute
• 1f92660: 8281057: Fix doc references to overriding in JLS
• 010965c: 8281023: NMT integration into pp debug command does not work
• 63a00a0: 8272777: Clean up remaining AccessController warnings in test library
• 5ab22e8: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
• fe547ea: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y
• a95ee5a: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled
• a46307a: Merge
• 2531c33: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
• fe0118f: 8279662: serviceability/sa/ClhsdbScanOops.java can fail do to unexpected GC
• ... and 43 more: https://git.openjdk.java.net/jdk/compare/bdda43e066b8da0ebf9a8ef2f843eabb230f0800...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealLucy]

Changes look good to me.
Nice performance gain for such a small change!

[TheRealMDoerr]

Thanks!
/integrate

[openjdk]

Going to push as commit 46c6c6f.
Since your change was applied there have been 59 commits pushed to the master branch:

• c936e70: 8280593: [PPC64, S390] redundant allocation of MacroAssembler in StubGenerator ctor
• 63e11cf: 8280970: Cleanup dead code in java.security.Provider
• e44dc63: 8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack
• b6935df: 8251505: Use of types in compiler shared code should be consistent.
• 130cf46: 4750574: (se spec) Selector spec should clarify calculation of select return value
• cda9c30: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call
• 86c24b3: 8240908: RetransformClass does not know about MethodParameters attribute
• 1f92660: 8281057: Fix doc references to overriding in JLS
• 010965c: 8281023: NMT integration into pp debug command does not work
• 63a00a0: 8272777: Clean up remaining AccessController warnings in test library
• ... and 49 more: https://git.openjdk.java.net/jdk/compare/bdda43e066b8da0ebf9a8ef2f843eabb230f0800...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 46c6c6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.