Skip to content

8279535: C2: Dead code in PhaseIdealLoop::create_loop_nest after JDK-8276116 #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Feb 1, 2022

Removal of a couple lines of dead code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279535: C2: Dead code in PhaseIdealLoop::create_loop_nest after JDK-8276116

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7309/head:pull/7309
$ git checkout pull/7309

Update a local copy of the PR:
$ git checkout pull/7309
$ git pull https://git.openjdk.java.net/jdk pull/7309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7309

View PR using the GUI difftool:
$ git pr show -t 7309

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7309.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2022

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@rwestrel The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 1, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2022

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279535: C2: Dead code in PhaseIdealLoop::create_loop_nest after JDK-8276116

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 5080e81: 8280770: serviceability/sa/ClhsdbThreadContext.java sometimes fails with 'Thread "SteadyStateThread"' missing from stdout/stderr
  • 1f6fcbe: 8278475: G1 dirty card refinement by Java threads may get unnecessarily paused
  • c5a8612: 8280458: G1: Remove G1BlockOffsetTablePart::_next_offset_threshold
  • 86debf4: 8280932: G1: Rename HeapRegionRemSet::_code_roots accessors
  • d37fb1d: 8280870: Parallel: Simplify CLD roots claim in Full GC cycle
  • 18a7dc8: 8279586: [macos] custom JCheckBox and JRadioBox with custom icon set: focus is still displayed after unchecking
  • 16ec47d: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
  • de3113b: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos
  • 0e70d45: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • 1ea0146: 8281007: Test jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java fails after JDK-8280738
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/973dda5ce0747a8ea67ec3a34c2ef2a0b2b6b140...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2022
@rwestrel
Copy link
Contributor Author

rwestrel commented Feb 2, 2022

@TobiHartmann thanks for the review.

@rwestrel
Copy link
Contributor Author

rwestrel commented Feb 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

Going to push as commit 4304a77.
Since your change was applied there have been 51 commits pushed to the master branch:

  • ab63834: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 48a32b5: 8280976: Incorrect encoding of avx512 vpsraq instruction with mask and constant shift.
  • 97af323: 8280842: Access violation in ciTypeFlow::profiled_count
  • d32f99e: 8279219: [REDO] C2 crash when allocating array of size too large
  • 85d839f: 8280601: ClhsdbThreadContext.java test is triggering codecache related asserts
  • 9ca7ff3: 8281082: Improve javadoc references to JOSS
  • c74b8f4: 8275914: SHA3: changing java implementation to help C2 create high-performance code
  • a18beb4: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs
  • fdd9ca7: 8280642: ObjectInputStream.readObject should throw InvalidClassException instead of IllegalAccessError
  • d95de5c: 8255495: Support CDS Archived Heap for uncompressed oops
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/973dda5ce0747a8ea67ec3a34c2ef2a0b2b6b140...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 2, 2022
@openjdk openjdk bot closed this Feb 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@rwestrel Pushed as commit 4304a77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants