-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8254995: [x86] ControlWord::print(), rc/pc variables might not be initialized #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer to use fatal() with printing unexpected value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@shipilev Since your change was applied there have been 51 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ee6eb98. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Static analyzers complain that in
ControlWord::print()
,rc
/pc
variables might not be initialized. This never happens in practice, becauserounding_control()
andprecision_control()
return the good values. We can make it cleaner to silence the compiler.Testing:
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/731/head:pull/731
$ git checkout pull/731