8254995: [x86] ControlWord::print(), rc/pc variables might not be initialized

[shipilev]

Static analyzers complain that in ControlWord::print(), rc/pc variables might not be initialized. This never happens in practice, because rounding_control() and precision_control() return the good values. We can make it cleaner to silence the compiler.

Testing:

• Linux x86_64 tier1

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8254995: [x86] ControlWord::print(), rc/pc variables might not be initialized

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/731/head:pull/731
$ git checkout pull/731

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (eb1705a)
• 00: Full (dc6c118)

[vnkozlov]

We prefer to use fatal() with printing unexpected value.

[vnkozlov]

Good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254995: [x86] ControlWord::print(), rc/pc variables might not be initialized

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 3267b09: 8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators
• cb6167b: 8254557: Compiler crashes with java.lang.AssertionError: isSubtype UNKNOWN
• 40f847e: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
• f167a71: 8254264: Remove redundant cross_modify_fence()
• 44f9271: 8254974: Fix stutter typo in TypeElement
• 76fdd7f: 8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds
• cdc8c40: 8254878: Move last piece of ZArray to GrowableArray
• 294e070: 8254998: C2: assert(!n->as_Loop()->is_transformed_long_loop()) failure with -XX:StressLongCountedLoop=1
• 3ee0380: 8234393: [macos] printing ignores printer tray
• 3f9c8a3: 8254966: Remove unused code from Matcher
• ... and 39 more: https://git.openjdk.java.net/jdk/compare/51a865d66a5dddbbaaa4bb656fa02ecd1bee1a0b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 51 commits pushed to the master branch:

• e577c8c: 8253641: Missing newline in the printout of certain JFR events
• 89e5444: 8254788: Dead code in the sun.java2d.xr.XRPMBlitLoops$XrSwToPMBlit
• 3267b09: 8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators
• cb6167b: 8254557: Compiler crashes with java.lang.AssertionError: isSubtype UNKNOWN
• 40f847e: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
• f167a71: 8254264: Remove redundant cross_modify_fence()
• 44f9271: 8254974: Fix stutter typo in TypeElement
• 76fdd7f: 8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds
• cdc8c40: 8254878: Move last piece of ZArray to GrowableArray
• 294e070: 8254998: C2: assert(!n->as_Loop()->is_transformed_long_loop()) failure with -XX:StressLongCountedLoop=1
• ... and 41 more: https://git.openjdk.java.net/jdk/compare/51a865d66a5dddbbaaa4bb656fa02ecd1bee1a0b...master

Your commit was automatically rebased without conflicts.

Pushed as commit ee6eb98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.