Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280956 Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y #7318

Closed
wants to merge 1 commit into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Feb 2, 2022

There are several source files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y that have the GPL header, need to check if they should be changed to GPL+CP.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7318/head:pull/7318
$ git checkout pull/7318

Update a local copy of the PR:
$ git checkout pull/7318
$ git pull https://git.openjdk.java.net/jdk pull/7318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7318

View PR using the GUI difftool:
$ git pr show -t 7318

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7318.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2022

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@savoptik
Copy link
Contributor Author

savoptik commented Feb 2, 2022

@forantar @azuev-java please review.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@savoptik The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 2, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2022

Webrevs

Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y

Reviewed-by: kizune, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 47800bf: 8280868: LineBodyHandlerTest.java creates and discards too many clients
  • 9d57853: 8281042: G1: Remove unused init_threshold in G1FullGCCompactionPoint
  • 87ab099: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism
  • ce71e8b: 8279917: Refactor subclassAudits in Thread to use ClassValue
  • 4ea6037: 8281035: Serial: Move RemoveForwardedPointerClosure to local scope
  • ae2504b: 8278254: Cleanup doclint warnings in java.desktop module
  • de826ba: 8280600: C2: assert(!had_error) failed: bad dominance
  • 4304a77: 8279535: C2: Dead code in PhaseIdealLoop::create_loop_nest after JDK-8276116
  • ab63834: 8280885: Shenandoah: Some tests failed with "EA: missing allocation reference path"
  • 48a32b5: 8280976: Incorrect encoding of avx512 vpsraq instruction with mask and constant shift.
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/86debf42f545a1aec0a065ebd5b016339a1ae09f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 2, 2022
@savoptik
Copy link
Contributor Author

savoptik commented Feb 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

Going to push as commit fe547ea.
Since your change was applied there have been 29 commits pushed to the master branch:

  • a95ee5a: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled
  • a46307a: Merge
  • 2531c33: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • fe0118f: 8279662: serviceability/sa/ClhsdbScanOops.java can fail do to unexpected GC
  • e3d5c9e: 8266974: duplicate property key in java.sql.rowset resource bundle
  • 47800bf: 8280868: LineBodyHandlerTest.java creates and discards too many clients
  • 9d57853: 8281042: G1: Remove unused init_threshold in G1FullGCCompactionPoint
  • 87ab099: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism
  • ce71e8b: 8279917: Refactor subclassAudits in Thread to use ClassValue
  • 4ea6037: 8281035: Serial: Move RemoveForwardedPointerClosure to local scope
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/86debf42f545a1aec0a065ebd5b016339a1ae09f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2022
@openjdk openjdk bot closed this Feb 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@savoptik Pushed as commit fe547ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants