Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes #732


Copy link

@shipilev shipilev commented Oct 19, 2020

The definition seems to be moved to CgroupSubsystem with JDK-8230305:

The leftover declaration can be cleaned up.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)


  • JDK-8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes



$ git fetch pull/732/head:pull/732
$ git checkout pull/732

Copy link

bridgekeeper bot commented Oct 19, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2020
Copy link

openjdk bot commented Oct 19, 2020

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Oct 19, 2020
Copy link

mlbridge bot commented Oct 19, 2020


Copy link

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

openjdk bot commented Oct 19, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • cb7701b: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid)
  • 4ffed32: 8254940: AArch64: Cleanup non-product thread members
  • cd66e0f: 8253877: gc/g1/ fails - missing "Evacuation failure" message
  • e76de18: 8223051: support loops with long (64b) trip counts
  • e9be2db: 8253453: SourceFileInfoTable should be allocated lazily
  • e10b538: 8243962: Various JVM TI tests time out using JFR on Windows
  • a1a3e9d: 8254882: ZGC: Use static_assert instead of guarantee
  • 8edc2f0: 8254912: ZGC: Change ZCollectionInterval type to double
  • 672f566: 8254874: ZGC: JNIHandleBlock verification failure in stack watermark processing
  • 98a395a: 8254880: ZGC: Let ZList iterators be alias templates
  • ... and 2 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2020
Copy link
Member Author


@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2020
Copy link

openjdk bot commented Oct 20, 2020

@shipilev Since your change was applied there have been 29 commits pushed to the master branch:

  • c87cdf7: 8254029: ObjectMonitor cleanup/minor bug-fix changes extracted from JDK-8253064
  • 7a580ca: 8255027: Problem list for Graal test gc/stress/
  • 6e8835c: 7110890: reg test TranslucentShapedFrameTest fails to create non-opaque frame
  • bf19581: 8255016: ConstantDescs.FALSE claims it represents TRUE
  • 0f4fb36: 8255032: Conflict between recent pushes breaks the build
  • cb5cdd7: 8254721: Improve support for conditionally generated files
  • 0001435: 8255020: Minor updates to docs jdk.incubator.vector
  • f42c032: 8254793: [JVMCI] improve speculation encoding
  • 74ac77e: 8247666: Support Lambda proxy classes in static CDS archive
  • ... and 19 more:

Your commit was automatically rebased without conflicts.

Pushed as commit 5b51085.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8254997-unimpl-container-read-mem-limit branch October 20, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-runtime integrated Pull request has been integrated
2 participants