Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272777: Clean up remaining AccessController warnings in test library #7328

Closed

Conversation

kevinjwalls
Copy link

@kevinjwalls kevinjwalls commented Feb 2, 2022

Reduce noise in test output by adding the @SuppressWarnings("removal") annotation (which has already been widely applied).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272777: Clean up remaining AccessController warnings in test library

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7328/head:pull/7328
$ git checkout pull/7328

Update a local copy of the PR:
$ git checkout pull/7328
$ git pull https://git.openjdk.java.net/jdk pull/7328/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7328

View PR using the GUI difftool:
$ git pr show -t 7328

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7328.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2022

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@kevinjwalls The following labels will be automatically applied to this pull request:

  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org security security-dev@openjdk.org net net-dev@openjdk.org labels Feb 2, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272777: Clean up remaining AccessController warnings in test library

Reviewed-by: rriggs, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • fe0118f: 8279662: serviceability/sa/ClhsdbScanOops.java can fail do to unexpected GC
  • e3d5c9e: 8266974: duplicate property key in java.sql.rowset resource bundle
  • 47800bf: 8280868: LineBodyHandlerTest.java creates and discards too many clients
  • 9d57853: 8281042: G1: Remove unused init_threshold in G1FullGCCompactionPoint
  • 87ab099: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism
  • ce71e8b: 8279917: Refactor subclassAudits in Thread to use ClassValue
  • 4ea6037: 8281035: Serial: Move RemoveForwardedPointerClosure to local scope
  • ae2504b: 8278254: Cleanup doclint warnings in java.desktop module
  • de826ba: 8280600: C2: assert(!had_error) failed: bad dominance
  • 4304a77: 8279535: C2: Dead code in PhaseIdealLoop::create_loop_nest after JDK-8276116
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/c74b8f48fad8380dbd811e4a42c361006e13021d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 2, 2022
@kevinjwalls
Copy link
Author

kevinjwalls commented Feb 3, 2022

Thanks Roger and Serguei!

@kevinjwalls
Copy link
Author

kevinjwalls commented Feb 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

Going to push as commit 63a00a0.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 5ab22e8: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
  • fe547ea: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y
  • a95ee5a: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled
  • a46307a: Merge
  • 2531c33: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • fe0118f: 8279662: serviceability/sa/ClhsdbScanOops.java can fail do to unexpected GC
  • e3d5c9e: 8266974: duplicate property key in java.sql.rowset resource bundle
  • 47800bf: 8280868: LineBodyHandlerTest.java creates and discards too many clients
  • 9d57853: 8281042: G1: Remove unused init_threshold in G1FullGCCompactionPoint
  • 87ab099: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/c74b8f48fad8380dbd811e4a42c361006e13021d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2022
@openjdk openjdk bot closed this Feb 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@kevinjwalls Pushed as commit 63a00a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org
3 participants