-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8254976: Re-enable swing jtreg tests which were broken due to samevm mode #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add swing |
@prsadhuk |
Webrevs
|
Since this re-enables quite a few tests, please can we run the jtreg desktop tests several times on each platform to be |
I have rerun the open jtreg tests several times (link in JBS) and those are stable apart from one test which I have added back. |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 114 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prsadhuk Since your change was applied there have been 114 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1b7ddeb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Few tests were problemlisted in an earlier test sprint due to those failing in mach5 testing.
It was found out that these test were failing due to those jtreg tests being run in same vm mode.
The bug was fixed by the adding client tests to the "othervm.dirs" in the TEST.ROOT so there is no need to keep those tests problem listed.
mach5 job running these tests was ok. Link in JBS.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/733/head:pull/733
$ git checkout pull/733