8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack #7331

dean-long · 2022-02-03T04:11:38Z

Reproduced the problem with a new JASM test rather than relying on idiosyncrasies of javac.
The fix is to not look at the next instruction (which might be the beginning of an unreachable block) if the current instruction doesn't fall through (like "goto"!).

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack

Reviewers

Vladimir Ivanov (@iwanowww - Reviewer)
Tobias Hartmann (@TobiHartmann - Reviewer)

Contributors

Yi Yang <yyang@openjdk.org>
Yi Yang <qingfeng.yy@alibaba-inc.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7331/head:pull/7331
$ git checkout pull/7331

Update a local copy of the PR:
$ git checkout pull/7331
$ git pull https://git.openjdk.java.net/jdk pull/7331/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7331

View PR using the GUI difftool:
$ git pr show -t 7331

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7331.diff

bridgekeeper · 2022-02-03T04:13:11Z

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-02-03T04:15:04Z

@dean-long The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk · 2022-02-03T04:15:19Z

@dean-long Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

dean-long · 2022-02-03T04:15:26Z

/cc hotspot-compiler

openjdk · 2022-02-03T04:16:33Z

@dean-long
The hotspot-compiler label was successfully added.

mlbridge · 2022-02-03T04:20:40Z

Webrevs

00: Full (615ba838)

iwanowww

Looks good.

openjdk · 2022-02-03T06:50:25Z

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack

Co-authored-by: Yi Yang <yyang@openjdk.org>
Co-authored-by: Yi Yang <qingfeng.yy@alibaba-inc.com>
Reviewed-by: vlivanov, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

b6935df: 8251505: Use of types in compiler shared code should be consistent.
130cf46: 4750574: (se spec) Selector spec should clarify calculation of select return value
cda9c30: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call
86c24b3: 8240908: RetransformClass does not know about MethodParameters attribute
1f92660: 8281057: Fix doc references to overriding in JLS
010965c: 8281023: NMT integration into pp debug command does not work
63a00a0: 8272777: Clean up remaining AccessController warnings in test library
5ab22e8: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
fe547ea: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y
a95ee5a: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled
... and 16 more: https://git.openjdk.java.net/jdk/compare/85d839fb4f3f820d130ea95f9a54ae137a95c20a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

TobiHartmann

Looks good to me too.

dean-long · 2022-02-03T21:58:03Z

Thanks Tobias and Vladimir!

openjdk · 2022-02-03T21:59:03Z

@dean-long Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

openjdk · 2022-02-03T21:59:22Z

@dean-long Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

openjdk · 2022-02-03T21:59:52Z

@dean-long Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

openjdk · 2022-02-03T22:01:00Z

@dean-long Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

dean-long · 2022-02-03T22:01:25Z

/contributor add @kelthuzadx
/contributor add yyang
/contributor add Yi Yang qingfeng.yy@alibaba-inc.com

openjdk · 2022-02-03T22:02:31Z

@dean-long
Contributor Yi Yang <yyang@openjdk.org> successfully added.

openjdk · 2022-02-03T22:04:03Z

@dean-long
Contributor Yi Yang <yyang@openjdk.org> successfully added.

openjdk · 2022-02-03T22:06:00Z

@dean-long
Contributor Yi Yang <qingfeng.yy@alibaba-inc.com> successfully added.

dean-long · 2022-02-03T22:09:22Z

/integrate

openjdk · 2022-02-03T22:10:59Z

Going to push as commit e44dc63.
Since your change was applied there have been 26 commits pushed to the master branch:

b6935df: 8251505: Use of types in compiler shared code should be consistent.
130cf46: 4750574: (se spec) Selector spec should clarify calculation of select return value
cda9c30: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call
86c24b3: 8240908: RetransformClass does not know about MethodParameters attribute
1f92660: 8281057: Fix doc references to overriding in JLS
010965c: 8281023: NMT integration into pp debug command does not work
63a00a0: 8272777: Clean up remaining AccessController warnings in test library
5ab22e8: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
fe547ea: 8280956: Re-examine copyright headers on files in src/java.desktop/macosx/native/libawt_lwawt/awt/a11y
a95ee5a: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled
... and 16 more: https://git.openjdk.java.net/jdk/compare/85d839fb4f3f820d130ea95f9a54ae137a95c20a...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-02-03T22:11:15Z

@dean-long Pushed as commit e44dc63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Don't look at next bytecode if the current bytecode doesn't fall through

615ba83

dean-long marked this pull request as ready for review February 3, 2022 04:12

openjdk bot added the rfr Pull request is ready for review label Feb 3, 2022

openjdk bot added the hotspot hotspot-dev@openjdk.org label Feb 3, 2022

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 3, 2022

iwanowww approved these changes Feb 3, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Feb 3, 2022

TobiHartmann approved these changes Feb 3, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Feb 3, 2022

openjdk bot closed this Feb 3, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2022

mhaessig mentioned this pull request May 8, 2025

8336906: C2: assert(bb->is_reachable()) failed: getting result from unreachable basicblock #25118

Closed

5 tasks

8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack #7331

8271055: Crash during deoptimization with "assert(bb->is_reachable()) failed: getting result from unreachable basicblock" with -XX:+VerifyStack #7331

Uh oh!

Conversation

dean-long commented Feb 3, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Contributors

Reviewing

Uh oh!

bridgekeeper bot commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

dean-long commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

mlbridge bot commented Feb 3, 2022

Webrevs

Uh oh!

iwanowww left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Feb 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TobiHartmann left a comment

Choose a reason for hiding this comment

Uh oh!

dean-long commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

dean-long commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

dean-long commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

openjdk bot commented Feb 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

dean-long commented Feb 3, 2022 •

edited by openjdk bot

Loading

openjdk bot commented Feb 3, 2022 •

edited

Loading