Skip to content

8280896: java/nio/file/Files/probeContentType/Basic.java fails on Windows 11#7334

Closed
turbanoff wants to merge 1 commit intoopenjdk:masterfrom
turbanoff:8280896_fix_probeContentType_Basic_test
Closed

8280896: java/nio/file/Files/probeContentType/Basic.java fails on Windows 11#7334
turbanoff wants to merge 1 commit intoopenjdk:masterfrom
turbanoff:8280896_fix_probeContentType_Basic_test

Conversation

@turbanoff
Copy link
Member

@turbanoff turbanoff commented Feb 3, 2022

Test fails because actual content type application/jar is not in allowed list of types: application/java-archive, application/x-java-archive.
But Amazon Corretto installer set this content type to Windows registry.
изображение
I propose to add this value to expected list.
Test always fails for me. After fix, test passes. Windows 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280896: java/nio/file/Files/probeContentType/Basic.java fails on Windows 11

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7334/head:pull/7334
$ git checkout pull/7334

Update a local copy of the PR:
$ git checkout pull/7334
$ git pull https://git.openjdk.java.net/jdk pull/7334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7334

View PR using the GUI difftool:
$ git pr show -t 7334

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7334.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Feb 3, 2022
@turbanoff turbanoff marked this pull request as ready for review February 3, 2022 10:32
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 3, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2022

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jaikiran
Copy link
Member

This change looks fine to me. You'll however need a Reviewer for this to be approved.

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280896: java/nio/file/Files/probeContentType/Basic.java fails on Windows 11

Reviewed-by: jpai, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 465 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 21, 2022
@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit f9137cb.
Since your change was applied there have been 498 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@turbanoff Pushed as commit f9137cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the 8280896_fix_probeContentType_Basic_test branch October 27, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated nio nio-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants