8280896: java/nio/file/Files/probeContentType/Basic.java fails on Windows 11#7334
8280896: java/nio/file/Files/probeContentType/Basic.java fails on Windows 11#7334turbanoff wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into |
|
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
This change looks fine to me. You'll however need a Reviewer for this to be approved. |
|
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 465 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit f9137cb.
Your commit was automatically rebased without conflicts. |
|
@turbanoff Pushed as commit f9137cb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Test fails because actual content type

application/jaris not in allowed list of types:application/java-archive,application/x-java-archive.But Amazon Corretto installer set this content type to Windows registry.
I propose to add this value to expected list.
Test always fails for me. After fix, test passes. Windows 11.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7334/head:pull/7334$ git checkout pull/7334Update a local copy of the PR:
$ git checkout pull/7334$ git pull https://git.openjdk.java.net/jdk pull/7334/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7334View PR using the GUI difftool:
$ git pr show -t 7334Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7334.diff