-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8281175: Add a -providerPath option to jarsigner #7338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8281175: Add a -providerPath option to jarsigner
/csr |
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
@wangweij this pull request will not be integrated until the CSR request JDK-8281230 for issue JDK-8281175 has been approved. |
@wangweij The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/label remove compiler |
@wangweij |
@wangweij |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except a minor comment. It's fine to me if you don't want to take it.
String path = null; | ||
path = PathList.appendPath( | ||
path, System.getProperty("java.class.path")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it more straightforward to use "String path = System.getProperty(...)", by combining line 254 and 255?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems so. I'll fix it.
Code change looks good to me. |
Correct. I've added some lines in the man page. |
Updated CSR looks good. |
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 121 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2ed1f4c.
Your commit was automatically rebased without conflicts. |
Add the
-providerPath
option to jarsigner to be consistent with keytool.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7338/head:pull/7338
$ git checkout pull/7338
Update a local copy of the PR:
$ git checkout pull/7338
$ git pull https://git.openjdk.java.net/jdk pull/7338/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7338
View PR using the GUI difftool:
$ git pr show -t 7338
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7338.diff