8279068: IGV: Update to work with JDK 16 and 17 #7347

robcasloz · 2022-02-04T12:30:52Z

This change upgrades the NetBeans Platform on which IGV is based to its latest version (12.6). The upgrade introduces support for JDK versions 16 and 17, and drops support for versions earlier than 11. The change adds a check to enforce that a supported JDK version is used when building IGV, emitting an informative error message otherwise.

Testing

Tested the following use cases manually on all combinations of (Linux, Windows, macOS) and (JDK 11, JDK 16, JDK 17):

build
open graph file (small.xml in test-input.zip)
import graphs via network (localhost)
expand groups in outline
open a graph
open a clone
zoom in and out
search a node
apply filters
extract a node
show all nodes
select nodes corresponding to a bytecode
view control flow
select nodes corresponding to a basic block
cluster nodes
show satellite view
compute the difference of two graphs
change node text
export graph as PDF
remove a group
save groups into a file
open a large graph file (large.xml in test-input.zip)
open a large graph ("After Escape Analysis" in large.xml)

Also tested that building IGV on JDK 8 and 18 (EA) fails with the error message "IGV requires a JDK version between 11 and 17".

Thanks to Jesper Wilhelmsson for helping with testing on macOS.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8279068: IGV: Update to work with JDK 16 and 17

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer)
Nils Eliasson (@neliasso - Reviewer)
Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7347/head:pull/7347
$ git checkout pull/7347

Update a local copy of the PR:
$ git checkout pull/7347
$ git pull https://git.openjdk.java.net/jdk pull/7347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7347

View PR using the GUI difftool:
$ git pr show -t 7347

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7347.diff

…havior)

bridgekeeper · 2022-02-04T12:31:42Z

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-02-04T12:34:34Z

@robcasloz The following labels will be automatically applied to this pull request:

build
hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

robcasloz · 2022-02-04T12:46:42Z

/label remove build

openjdk · 2022-02-04T12:46:53Z

@robcasloz
The build label was successfully removed.

mlbridge · 2022-02-16T14:43:48Z

Webrevs

00: Full (7cfb110b)

vnkozlov

Good.

openjdk · 2022-02-16T18:12:18Z

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279068: IGV: Update to work with JDK 16 and 17

Reviewed-by: kvn, neliasso, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 245 new commits pushed to the master branch:

1864481: 8279969: NULL return from map_bitmap_region() needs to be checked
1eec16b: 8281803: AArch64: Optimize masked vector NOT/AND_NOT for SVE
cd234f5: 8282007: Assorted enhancements to jpackage testing framework
b6e48e6: Merge
0f2113c: 8280415: Remove EA from JDK 18 version string starting with Initial RC promotion B35 on February 10, 2022
2be2a29: 8281713: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
0b00ce1: 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH%
5ec7898: 8281671: Class.getCanonicalName spec should explicitly cover array classes
9ba0760: 8275345: RasterFormatException when drawing a tiled image made of non-writable rasters
48f6e93: 8282020: ProblemList sun/net/www/protocol/https/HttpsURLConnection/B6216082.java until JDK-8282017 is fixed
... and 235 more: https://git.openjdk.java.net/jdk/compare/a07e19d8336f8fbea8736ba169787aec6d812817...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

neliasso

Looks good!

robcasloz · 2022-02-17T08:29:25Z

Thanks for reviewing, Vladimir and Nils!

chhagedorn

Nice update!

robcasloz · 2022-02-17T09:22:32Z

Thanks, Christian!

robcasloz · 2022-02-18T08:34:58Z

/integrate

openjdk · 2022-02-18T08:36:03Z

Going to push as commit 7bcca76.
Since your change was applied there have been 259 commits pushed to the master branch:

c928958: 8281936: compiler/arguments/TestCodeEntryAlignment.java fails on AVX512 machines
a22f422: 8037573: Typo in DefaultTreeModel docs: askAllowsChildren instead of asksAllowsChildren
fdce35f: 8282025: assert(ctrl != __null) failed: control out is assumed to be unique after JDK-8281732
f830cbe: 8188073: Add Capstone as backend for hsdis
69fc273: 8282075: ProblemList 3 compiler/whitebox tests on macosx-x64
1292776: 8281317: CompactNumberFormat displays 4-digit values when rounding to a new range
cd9a3cf: 8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"
a6f8a38: 8281000: ClassLoader::registerAsParallelCapable throws NPE if caller is null
4c7f8b4: 8268250: Class.arrayType() for a 255-d array throws undocumented IllegalArgumentException
d0e1180: 8282019: Unused static fields DEGREES_TO_RADIANS, RADIANS_TO_DEGREES in StrictMath
... and 249 more: https://git.openjdk.java.net/jdk/compare/a07e19d8336f8fbea8736ba169787aec6d812817...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-02-18T08:36:18Z

@robcasloz Pushed as commit 7bcca76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

robcasloz added 8 commits January 26, 2022 13:35

Update to latest NetBeans Platform version

540f078

Update instructions

0da920c

Update to latest Nashorn for compatibility with JDK 17

95de455

Simplify instructions

3266dd5

Allow Netbeans Platform to break encapsulation (needed for correct be…

35fede4

…havior)

Update copyright years

c36111c

Enforce JDK version

7add1c4

Pass all JVM options in a single line for Windows compatibility

7cfb110

openjdk bot added build build-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Feb 4, 2022

openjdk bot removed the build build-dev@openjdk.org label Feb 4, 2022

robcasloz marked this pull request as ready for review February 16, 2022 14:38

openjdk bot added the rfr Pull request is ready for review label Feb 16, 2022

vnkozlov approved these changes Feb 16, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2022

neliasso approved these changes Feb 16, 2022

View reviewed changes

chhagedorn approved these changes Feb 17, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Feb 18, 2022

openjdk bot closed this Feb 18, 2022

openjdk bot removed the ready Pull request is ready to be integrated label Feb 18, 2022

openjdk bot removed the rfr Pull request is ready for review label Feb 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8279068: IGV: Update to work with JDK 16 and 17 #7347

8279068: IGV: Update to work with JDK 16 and 17 #7347

robcasloz commented Feb 4, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Feb 4, 2022

openjdk bot commented Feb 4, 2022

robcasloz commented Feb 4, 2022

openjdk bot commented Feb 4, 2022

mlbridge bot commented Feb 16, 2022

vnkozlov left a comment

openjdk bot commented Feb 16, 2022 •

edited

Loading

neliasso left a comment

robcasloz commented Feb 17, 2022

chhagedorn left a comment

robcasloz commented Feb 17, 2022

robcasloz commented Feb 18, 2022

openjdk bot commented Feb 18, 2022

openjdk bot commented Feb 18, 2022

8279068: IGV: Update to work with JDK 16 and 17 #7347

8279068: IGV: Update to work with JDK 16 and 17 #7347

Conversation

robcasloz commented Feb 4, 2022 • edited by openjdk bot Loading

Testing

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Feb 4, 2022

openjdk bot commented Feb 4, 2022

robcasloz commented Feb 4, 2022

openjdk bot commented Feb 4, 2022

mlbridge bot commented Feb 16, 2022

Webrevs

vnkozlov left a comment

Choose a reason for hiding this comment

openjdk bot commented Feb 16, 2022 • edited Loading

neliasso left a comment

Choose a reason for hiding this comment

robcasloz commented Feb 17, 2022

chhagedorn left a comment

Choose a reason for hiding this comment

robcasloz commented Feb 17, 2022

robcasloz commented Feb 18, 2022

openjdk bot commented Feb 18, 2022

openjdk bot commented Feb 18, 2022

robcasloz commented Feb 4, 2022 •

edited by openjdk bot

Loading

openjdk bot commented Feb 16, 2022 •

edited

Loading