8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled

[AlekseiEfimov]

Hi,

JNDI's DnsClient can fail with UncheckedIOException during connect or disconnect method calls. It is a know behavior of DatagramSocket.

Currently, DnsClient method fast-fails when UncheckedIOException is observed during connect attempt. But it supposed to mark such server as invalid and continue checking other servers.

Testing: tier1, tier2, tier3 and existing JCK tests show no failures relevant to the proposed changed

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7353/head:pull/7353
$ git checkout pull/7353

Update a local copy of the PR:
$ git checkout pull/7353
$ git pull https://git.openjdk.java.net/jdk pull/7353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7353

View PR using the GUI difftool:
$ git pr show -t 7353

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7353.diff

[bridgekeeper]

👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlekseiEfimov The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c6e5b1f3)

[dfuch]

LGTM - and a good cleanup to boot!

[openjdk]

@AlekseiEfimov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• f3e8242: 8280965: Tests com/sun/net/httpserver/simpleserver fail with FileSystemException on Windows 11
• 95fd9d2: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
• f5e0870: 8281117: Add regression test for JDK-8280587
• f230282: 8281298: Revise the creation of unmodifiable list
• 5dfff74: 8166050: partialArray is not created in javax.swing.text.html.parser.NPrintWriter.println(...) method
• 2f48a3f: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10
• f7814c1: 8139173: [macosx] JInternalFrame shadow is not properly drawn
• 77b0240: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
• 42e272e: 8281289: Improve with List.copyOf
• 48523b0: 8281049: man page update for jstatd Security Manager dependency removal
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/51b53a821bb3cfb962f80a637f5fb8cde988975a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlekseiEfimov]

/integrate

[openjdk]

Going to push as commit 4c16949.
Since your change was applied there have been 17 commits pushed to the master branch:

• f3e8242: 8280965: Tests com/sun/net/httpserver/simpleserver fail with FileSystemException on Windows 11
• 95fd9d2: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
• f5e0870: 8281117: Add regression test for JDK-8280587
• f230282: 8281298: Revise the creation of unmodifiable list
• 5dfff74: 8166050: partialArray is not created in javax.swing.text.html.parser.NPrintWriter.println(...) method
• 2f48a3f: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10
• f7814c1: 8139173: [macosx] JInternalFrame shadow is not properly drawn
• 77b0240: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
• 42e272e: 8281289: Improve with List.copyOf
• 48523b0: 8281049: man page update for jstatd Security Manager dependency removal
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/51b53a821bb3cfb962f80a637f5fb8cde988975a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlekseiEfimov Pushed as commit 4c16949.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.