8281318: Improve jfr/event/allocation tests reliability

[shipilev]

This fixes the failure on x86_32 by resolving an object/TLAB "sizing" problem. On x86_32, the 100K object gets 200K TLAB, which allocates the next object exactly in the same TLAB. Bumping the object size to 128K resolves this.

Additionally, rewired the tests to match object sizes exactly. In modern JDK, the header size depends on UseCompressedClassPointers, not on UseCompressedOops. Using Whitebox, we can poll the VM configuration exactly.

Additional testing:

• Linux x86_32 fastdebug, jfr/event/allocation/
• Linux x86_64 fastdebug, jfr/event/allocation/, out of the box
• Linux x86_64 fastdebug, jfr/event/allocation/, with -XX:-UseCompressedClassPointers

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281318: Improve jfr/event/allocation tests reliability

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7365/head:pull/7365
$ git checkout pull/7365

Update a local copy of the PR:
$ git checkout pull/7365
$ git pull https://git.openjdk.java.net/jdk pull/7365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7365

View PR using the GUI difftool:
$ git pr show -t 7365

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7365.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7e35bf2f)

[mgronlun]

Looks good, thank you Aleksey.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281318: Improve jfr/event/allocation tests reliability

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• f3e8242: 8280965: Tests com/sun/net/httpserver/simpleserver fail with FileSystemException on Windows 11
• 95fd9d2: 8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
• f5e0870: 8281117: Add regression test for JDK-8280587
• f230282: 8281298: Revise the creation of unmodifiable list
• 5dfff74: 8166050: partialArray is not created in javax.swing.text.html.parser.NPrintWriter.println(...) method
• 2f48a3f: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10
• f7814c1: 8139173: [macosx] JInternalFrame shadow is not properly drawn
• 77b0240: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
• 42e272e: 8281289: Improve with List.copyOf
• 48523b0: 8281049: man page update for jstatd Security Manager dependency removal
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/63a00a0df24b154ef459936dbd69bcd2f0626235...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Looks good, thank you Aleksey.

Thanks! Anyone else to review?

[shipilev]

@mgronlun, I am going to integrate with just your review, OK?

[mgronlun]

That should be fine, thank you.

[shipilev]

/integrate

[openjdk]

Going to push as commit 65831eb.
Since your change was applied there have been 72 commits pushed to the master branch:

• eee6a56: 8281522: Rename ADLC classes which have the same name as hotspot variants
• 84868e3: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths
• 58c2bd3: 8281536: JFR: Improve jdk.jfr.ContentType documentation
• 83b6e4b: 8281294: [vectorapi] FIRST_NONZERO reduction operation throws IllegalArgumentExcept on zero vectors
• 039313d: 8054449: Incompatible type in example code in TreePath
• 3ce1c5b: 8280832: Update usage docs for NonblockingQueue
• d442328: 8281262: Windows builds in different directories are not fully reproducible
• c820d1a: 8281379: Assign package declarations to all jtreg test cases under gc
• fa0a72c: 8252496: C2: Useless code in MergeMemNode::Ideal
• 7218d84: 8281567: Remove @throws IOException from X509CRLImpl::getExtension docs
• ... and 62 more: https://git.openjdk.java.net/jdk/compare/63a00a0df24b154ef459936dbd69bcd2f0626235...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 65831eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mgronlun]

Can you take a look at this, https://bugs.openjdk.java.net/browse/JDK-8281638?

[shipilev]

Can you take a look at this, https://bugs.openjdk.java.net/browse/JDK-8281638?

Yes, acked! (Mumbles: always run in both VM modes, always run in both VM modes, always run in both VM modes, ...)