Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262721: Add Tests to verify single iteration loops are properly optimized #7368

Closed
wants to merge 1 commit into from

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Feb 7, 2022

That came up in previous:

#2529 (comment)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262721: Add Tests to verify single iteration loops are properly optimized

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7368/head:pull/7368
$ git checkout pull/7368

Update a local copy of the PR:
$ git checkout pull/7368
$ git pull https://git.openjdk.java.net/jdk pull/7368/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7368

View PR using the GUI difftool:
$ git pr show -t 7368

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7368.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2022

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 7, 2022
@openjdk
Copy link

openjdk bot commented Feb 7, 2022

@rwestrel The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Feb 7, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2022

Webrevs

Copy link

@neliasso neliasso left a comment

Looks good! Approved.

@openjdk
Copy link

openjdk bot commented Feb 8, 2022

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262721: Add Tests to verify single iteration loops are properly optimized

Reviewed-by: neliasso, chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 8, 2022
Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good!

@rwestrel
Copy link
Contributor Author

rwestrel commented Feb 8, 2022

@neliasso @chhagedorn thanks for the reviews.

@rwestrel
Copy link
Contributor Author

rwestrel commented Feb 8, 2022

@vnkozlov are the proposed tests what you had in mind?

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Yes, this is exactly what I wanted.

@rwestrel
Copy link
Contributor Author

rwestrel commented Feb 9, 2022

@vnkozlov thanks for looking at this.

@rwestrel
Copy link
Contributor Author

rwestrel commented Feb 9, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 9, 2022

Going to push as commit 69e390a.
Since your change was applied there have been 43 commits pushed to the master branch:

  • f092bab: 8281195: Mistakenly used logging causes significant overhead in interpreter
  • f924e50: 8281440: AWT: Conversion from string literal loses const qualifier
  • 072e7b4: 8272807: Permit use of memory concurrent with pretouch
  • cb2f8ca: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working
  • fc77217: 8281168: Micro-optimize VarForm.getMemberName for interpreter
  • bce5dd1: 8280438: Improve BufferNode::Allocator::release to avoid walking pending list
  • 13f739d: 8280830: Change NonblockingQueue::try_pop variable named "result"
  • 2f46af0: 8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder
  • fb17a8e: 8278947: Support for array constants in constant table
  • d658d94: 8280828: Improve invariants in NonblockingQueue::append
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/3d926dd66ef6551e91a4ebbbc59dcff58f5ede5a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 9, 2022
@openjdk openjdk bot closed this Feb 9, 2022
@openjdk openjdk bot removed ready rfr labels Feb 9, 2022
@openjdk
Copy link

openjdk bot commented Feb 9, 2022

@rwestrel Pushed as commit 69e390a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
4 participants