Skip to content

6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java #7371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Feb 7, 2022

Trivial comment and exception text update, correcting a bug ID to make more sense.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7371/head:pull/7371
$ git checkout pull/7371

Update a local copy of the PR:
$ git checkout pull/7371
$ git pull https://git.openjdk.java.net/jdk pull/7371/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7371

View PR using the GUI difftool:
$ git pr show -t 7371

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7371.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2022

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 7, 2022
@openjdk
Copy link

openjdk bot commented Feb 7, 2022

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Feb 7, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 7, 2022

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

Reviewed-by: cjplummer, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 1dfc94d: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.
  • 2ed1f4c: 8281175: Add a -providerPath option to jarsigner
  • a0f6f24: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR
  • 22a1a32: 8268387: Rename maximum compaction to maximal compaction in G1
  • 7667771: 8281114: G1: Remove PreservedMarks::init_forwarded_mark
  • 4c16949: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 7, 2022
Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinjwalls
Copy link
Contributor Author

Thanks Chris, thanks Daniel!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 7, 2022

Going to push as commit 8a66210.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 1dfc94d: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.
  • 2ed1f4c: 8281175: Add a -providerPath option to jarsigner
  • a0f6f24: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR
  • 22a1a32: 8268387: Rename maximum compaction to maximal compaction in G1
  • 7667771: 8281114: G1: Remove PreservedMarks::init_forwarded_mark
  • 4c16949: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 7, 2022
@openjdk openjdk bot closed this Feb 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 7, 2022
@openjdk
Copy link

openjdk bot commented Feb 7, 2022

@kevinjwalls Pushed as commit 8a66210.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants