JDK-8281450: Remove unnecessary operator new and delete from ObjectMonitor

[tstuefe]

Trivial (?) patch to remove ObjectMonitor operator new and delete. Since ObjectMonitor derives from CHeapObj, we don't need those.

This also solves the problem that the local new overrules the NMT category flag set in CHeapObj (both currently are mtInternal, so the problem is theoretical).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281450: Remove unnecessary operator new and delete from ObjectMonitor

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7377/head:pull/7377
$ git checkout pull/7377

Update a local copy of the PR:
$ git checkout pull/7377
$ git pull https://git.openjdk.java.net/jdk pull/7377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7377

View PR using the GUI difftool:
$ git pr show -t 7377

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7377.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (17efee08)

[dholmes-ora]

Hi Thomas,

Initially I was a bit confused as I found the ADLC definition of CHeapObj :) But now I see this is a trivial cleanup.

Thanks,
David

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281450: Remove unnecessary operator new and delete from ObjectMonitor

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• f5d8ceb: 8281296: Create a regression test for JDK-4515999
• 861f279: 8280917: Simplify G1ConcurrentRefineThread activation
• f2a9627: 8279329: Remove hardcoded IPv4 available policy on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Hi Thomas,

Initially I was a bit confused as I found the ADLC definition of CHeapObj :) But now I see this is a trivial cleanup.

Thanks, David

:-) I keep having this problem with our Arena code. Reminds me that I wanted to ask Vladimir K whether it's ok to rename the ADLC versions...

Thanks for the thumbs up!

[tstuefe]

/integrate

[openjdk]

Going to push as commit 83d6745.
Since your change was applied there have been 3 commits pushed to the master branch:

• f5d8ceb: 8281296: Create a regression test for JDK-4515999
• 861f279: 8280917: Simplify G1ConcurrentRefineThread activation
• f2a9627: 8279329: Remove hardcoded IPv4 available policy on Windows

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit 83d6745.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.