8281440: AWT: Conversion from string literal loses const qualifier

[djelinski]

This patch fixes AWT compilation under VisualStudio 2019 with /Zc:strictStrings enabled.

Strict string handling is already enabled in GCC and Clang. With some effort we should be able to enable it in MSVC as well.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281440: AWT: Conversion from string literal loses const qualifier

Reviewers

• Phil Race (@prrace - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7379/head:pull/7379
$ git checkout pull/7379

Update a local copy of the PR:
$ git checkout pull/7379
$ git pull https://git.openjdk.java.net/jdk pull/7379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7379

View PR using the GUI difftool:
$ git pr show -t 7379

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7379.diff

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (74f5ca19)

[prrace]

I assume no problems building with 2017 either ?

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281440: AWT: Conversion from string literal loses const qualifier

Reviewed-by: prr, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 072e7b4: 8272807: Permit use of memory concurrent with pretouch
• cb2f8ca: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working
• fc77217: 8281168: Micro-optimize VarForm.getMemberName for interpreter
• bce5dd1: 8280438: Improve BufferNode::Allocator::release to avoid walking pending list
• 13f739d: 8280830: Change NonblockingQueue::try_pop variable named "result"
• 2f46af0: 8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder
• fb17a8e: 8278947: Support for array constants in constant table
• d658d94: 8280828: Improve invariants in NonblockingQueue::append
• 5fb56db: 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java
• 92f4f40: 8281104: jar --create should create missing parent directories
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/2f71a6b39ed6bb869b4eb3e81bc1d87f4b3328ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[djelinski]

VS 2017 build also works with these changes, just checked.

[djelinski]

/integrate

[openjdk]

@djelinski
Your change (at version 74f5ca1) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit f924e50.
Since your change was applied there have been 17 commits pushed to the master branch:

• 072e7b4: 8272807: Permit use of memory concurrent with pretouch
• cb2f8ca: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working
• fc77217: 8281168: Micro-optimize VarForm.getMemberName for interpreter
• bce5dd1: 8280438: Improve BufferNode::Allocator::release to avoid walking pending list
• 13f739d: 8280830: Change NonblockingQueue::try_pop variable named "result"
• 2f46af0: 8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder
• fb17a8e: 8278947: Support for array constants in constant table
• d658d94: 8280828: Improve invariants in NonblockingQueue::append
• 5fb56db: 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java
• 92f4f40: 8281104: jar --create should create missing parent directories
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/2f71a6b39ed6bb869b4eb3e81bc1d87f4b3328ff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @djelinski Pushed as commit f924e50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.