8281523: Accessibility: Conversion from string literal loses const qualifier

[djelinski]

This patch fixes jdk.accessibility compilation under VisualStudio 2019 with /Zc:strictStrings enabled.

Strict string handling is already enabled in GCC and Clang. With some effort we should be able to enable it in MSVC as well.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281523: Accessibility: Conversion from string literal loses const qualifier

Reviewers

• Phil Race (@prrace - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7380/head:pull/7380
$ git checkout pull/7380

Update a local copy of the PR:
$ git checkout pull/7380
$ git pull https://git.openjdk.java.net/jdk pull/7380/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7380

View PR using the GUI difftool:
$ git pr show -t 7380

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7380.diff

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (fc67bf6e)
• 00: Full (8576f911)

[djelinski]

Hi, can I get a review for this change?
This is similar to #7379, but in a different subcomponent (Accessibility vs. AWT). I added const qualifier to a bunch of function parameters.

Additionally I removed one (unused) function and one (mismatching) function declaration; build passed, tier1 and tier2 green. Verified with both vs2019 and vs2017.

[prrace]

Deleting this function - without comment ! - seems to be somewhat out of scope here.

[djelinski]

Reverted.

I removed this function because its definition (PrintJavaDebugString2) did not match the declaration (PrintJavaDebugString), so the function wasn't really usable. I'm fine with leaving it as is, or cleaning up separately.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281523: Accessibility: Conversion from string literal loses const qualifier

Reviewed-by: prr, aivanov, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 151 new commits pushed to the master branch:

• cc7cf81: 8280861: Robot color picker broken on Linux with scaling above 100%
• d7a706a: 8253757: Add LLVM-based backend for hsdis
• bdae1d8: 8282147: [TESTBUG] waitForIdle after creating frame in JSpinnerMouseAndKeyPressTest.java
• 51f4420: 8282130: (bf) Remove unused ARRAY_BASE_OFFSET, ARRAY_INDEX_SCALE from read-only Heap Buffers
• 34aae32: 8282166: JDK-8282158 changed ECParameters' package by accident
• c5d9142: 8282096: G1: Remove redundant checks in G1CardSet::free_mem_object
• 52a85d8: 8282158: ECParameters InvalidParameterSpecException messages missed ECKeySizeParameterSpec
• 4e0b81c: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/
• 8563d86: 8282085: The REGISTER_DEFINITION macro is useless after JDK-8269122
• d28b048: 8281815: x86: Use short jumps in TIG::generate_slow_signature_handler
• ... and 141 more: https://git.openjdk.java.net/jdk/compare/2f71a6b39ed6bb869b4eb3e81bc1d87f4b3328ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @aivanov-jdk, @azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[djelinski]

/integrate

[openjdk]

@djelinski
Your change (at version fc67bf6) is now ready to be sponsored by a Committer.

[djelinski]

hi, could you sponsor this? It's already integrated. Thank you!

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit e1c98bd.
Since your change was applied there have been 151 commits pushed to the master branch:

• cc7cf81: 8280861: Robot color picker broken on Linux with scaling above 100%
• d7a706a: 8253757: Add LLVM-based backend for hsdis
• bdae1d8: 8282147: [TESTBUG] waitForIdle after creating frame in JSpinnerMouseAndKeyPressTest.java
• 51f4420: 8282130: (bf) Remove unused ARRAY_BASE_OFFSET, ARRAY_INDEX_SCALE from read-only Heap Buffers
• 34aae32: 8282166: JDK-8282158 changed ECParameters' package by accident
• c5d9142: 8282096: G1: Remove redundant checks in G1CardSet::free_mem_object
• 52a85d8: 8282158: ECParameters InvalidParameterSpecException messages missed ECKeySizeParameterSpec
• 4e0b81c: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/
• 8563d86: 8282085: The REGISTER_DEFINITION macro is useless after JDK-8269122
• d28b048: 8281815: x86: Use short jumps in TIG::generate_slow_signature_handler
• ... and 141 more: https://git.openjdk.java.net/jdk/compare/2f71a6b39ed6bb869b4eb3e81bc1d87f4b3328ff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @djelinski Pushed as commit e1c98bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.