8281507: Two javac tests have bad jtreg @clean tags

[shipilev]

Apparently, jtreg does not support * globbing. It now throws errors for upcoming jtreg 7.

Additional testing:

• Affected tests still pass

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281507: Two javac tests have bad jtreg @clean tags

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7398/head:pull/7398
$ git checkout pull/7398

Update a local copy of the PR:
$ git checkout pull/7398
$ git pull https://git.openjdk.java.net/jdk pull/7398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7398

View PR using the GUI difftool:
$ git pr show -t 7398

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7398.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (598f013f)
• 00: Full (15b4a79f)

[jonathan-gibbons]

Suggest using @clean * to remove all previously compiled class files for the test. This seems closest to the original intent.

[shipilev]

@jonathan-gibbons, please ack this?

[shipilev]

Paging @jonathan-gibbons or anybody else :)

[shipilev]

Anyone? :)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281507: Two javac tests have bad jtreg `@clean` tags

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 233 new commits pushed to the master branch:

• bf19fc6: 8280357: user.home = "?" when running with systemd DynamicUser=true
• b6843a1: 8005885: enhance PrintCodeCache to print more data
• 23995f8: 8281525: Enable Zc:strictStrings flag in Visual Studio build
• 20e78f7: 8282307: Parallel: Incorrect discovery mode in PCReferenceProcessor
• 0b6862e: 8282348: Remove unused CardTable::dirty_card_iterate
• 6fab8a2: 8277204: Implement PAC-RET branch protection on Linux/AArch64
• abc0ce1: 8282316: Operation before String case conversion
• 0796620: 8281944: JavaDoc throws java.lang.IllegalStateException: ERRONEOUS
• 231e48f: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422
• f4486a1: 8262400: runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java fails in test_ame5_compiled_vtable_stub with wrapper
• ... and 223 more: https://git.openjdk.java.net/jdk/compare/63a00a0df24b154ef459936dbd69bcd2f0626235...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thank you.

/integrate

[openjdk]

Going to push as commit 86723d4.
Since your change was applied there have been 245 commits pushed to the master branch:

• 630ad1a: 8282428: ProblemList jdk/jfr/jvm/TestWaste.java
• afd4bcb: 8282398: EndingDotHostname.java test fails because SSL cert expired
• cf6d256: 8282153: JFR: Check for recording waste
• c5c6058: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
• fb8bf81: 8279995: jpackage --add-launcher option should allow overriding description
• 441e485: 8281739: JFR: Use message with Objects.requireNonNull
• e96c599: 8271232: JFR: Scrub recording data
• 735e86b: 8282345: handle latest VS2022 in abstract_vm_version
• b96b743: 8281015: Further simplify NMT backend
• 9471f24: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
• ... and 235 more: https://git.openjdk.java.net/jdk/compare/63a00a0df24b154ef459936dbd69bcd2f0626235...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 86723d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.