Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253768: Deleting unused pipe_class definitions in adl-file (x86_64.ad). #74

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2020

/issue create hotspot/compiler

This is just removing some dead/unused code. More importantly, this is a test of the new "issue create" support in Skara.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253768: Deleting unused pipe_class definitions in adl-file (x86_64.ad).

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/74/head:pull/74
$ git checkout pull/74

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2020

👋 Welcome back phedlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@phedlin An error occurred when attempting to create an issue: No value present

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@phedlin The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 8, 2020
@ghost
Copy link
Author

ghost commented Sep 8, 2020

Deleting unused pipe_class definitions in adl-file (x86_64.ad).
/issue create hotspot/compiler

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@phedlin An error occurred when attempting to create an issue: No value present

@ghost
Copy link
Author

ghost commented Sep 28, 2020

/issue create hotspot/compiler

@openjdk
Copy link

openjdk bot commented Sep 28, 2020

@phedlin An error occurred when attempting to create an issue: No value present

@ghost
Copy link
Author

ghost commented Sep 29, 2020

/issue create hotspot/compiler

@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@phedlin An error occurred when attempting to create an issue: No value present

@ghost
Copy link
Author

ghost commented Sep 29, 2020

/issue create hotspot/compiler

@openjdk openjdk bot changed the title Deleting unused pipe_class definitions in adl-file (x86_64.ad). 8253768: Deleting unused pipe_class definitions in adl-file (x86_64.ad). Sep 29, 2020
@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@phedlin The issue JDK-8253768 was successfully created - the title of this PR will be updated to reference it.

@ghost ghost marked this pull request as ready for review September 29, 2020 10:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2020

Webrevs

Copy link

@neliasso neliasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@phedlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253768: Deleting unused pipe_class definitions in adl-file (x86_64.ad).

Reviewed-by: neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 267 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2020
@ghost
Copy link
Author

ghost commented Sep 29, 2020

Thanks for reviewing Nils.

@ghost
Copy link
Author

ghost commented Sep 29, 2020

/test

@openjdk
Copy link

openjdk bot commented Sep 29, 2020

Could not create test job

@ghost
Copy link
Author

ghost commented Sep 30, 2020

/integrate

@openjdk openjdk bot closed this Sep 30, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2020
@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@phedlin Since your change was applied there have been 286 commits pushed to the master branch:

  • dc3a0f5: 8253183: Fragile memory barrier selection for some weak memory model platforms
  • 8331e63: 8253778: ShenandoahSafepoint::is_at_shenandoah_safepoint should not access VMThread state from other threads
  • 4c65365: 8253792: javax.swing.text.GapContent documentation typos
  • 3078b5f: 6441211: Small Error in API at javax.swing.plaf.synth.Region
  • 4622a18: 8253791: Issue with useAppleColor check in CSystemColors.m
  • ac02afe: 8253721: Flag -XX:AVX3Threshold does not accept Zero value
  • 4d9f207: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac
  • 1eca634: 8252000: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdb
  • a55cde4: 8252002: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdwp
  • ffc97ba: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
  • ... and 276 more: https://git.openjdk.java.net/jdk/compare/0dadf81e149c4a6f5496dd23675e3986efe157f3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 04775f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
1 participant