8254967: com.sun.net.HttpsServer spins on TLS session close #742
Conversation
|
👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into |
|
@Michael-Mc-Mahon The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| handshaking.lock(); | ||
| ByteBuffer tmp = allocate(BufType.APPLICATION); | ||
| WrapperResult r; | ||
| Status st; | ||
| HandshakeStatus hs; | ||
| do { | ||
| tmp.clear(); | ||
| tmp.flip (); | ||
| r = wrapper.wrapAndSendX (tmp, true); | ||
| } while (r.result.getStatus() != Status.CLOSED); | ||
| hs = r.result.getHandshakeStatus(); | ||
| st = r.result.getStatus(); | ||
| } while (st != Status.CLOSED && | ||
| !(st == Status.OK && hs == HandshakeStatus.NOT_HANDSHAKING)); | ||
| } finally { | ||
| handshaking.unlock(); | ||
| } |
There was a problem hiding this comment.
Ok. The expectation is that doClosure() only involves sending a close acknowedged and not receiving anything. This is probably correct if doClosure() is called on reception of close_notify. In which case the change looks reasonable. I also see that a further expectation is that cycles of NEED_WRAP/NEED_UNWRAP only happen during the handshake, which is hopefully true.
|
@Michael-Mc-Mahon This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 188 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
openjdk
bot
added
integrated
|
@Michael-Mc-Mahon Since your change was applied there have been 188 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 953e472. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This fixes a busy loop bug in the Http server which happens sometimes when an SSL connection is closed by the client.
There is no regression test as it is not easy to reproduce and the only effect is that one executor thread gets tied up.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/742/head:pull/742$ git checkout pull/742