Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8047749: javadoc for getPathBounds() in TreeUI and BasicTreeUI is incorrect #7421

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Feb 10, 2022

The javadoc descriptions for javax.swing.plaf.TreeUI.getPathBounds() and javax.swing.plaf.basic.BasicTreeUI.getPathBounds() have stated it returns null if any component in path is currently "valid", which is wrong.
The getPathBounds() in BasicTreeUI returns null if tree or treeState is null.
Fixed the javadoc.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8047749: javadoc for getPathBounds() in TreeUI and BasicTreeUI is incorrect

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7421/head:pull/7421
$ git checkout pull/7421

Update a local copy of the PR:
$ git checkout pull/7421
$ git pull https://git.openjdk.java.net/jdk pull/7421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7421

View PR using the GUI difftool:
$ git pr show -t 7421

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7421.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 10, 2022
@openjdk
Copy link

openjdk bot commented Feb 10, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 10, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 10, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 10, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8047749: javadoc for getPathBounds() in TreeUI and BasicTreeUI is incorrect

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • 039313d: 8054449: Incompatible type in example code in TreePath
  • 3ce1c5b: 8280832: Update usage docs for NonblockingQueue
  • d442328: 8281262: Windows builds in different directories are not fully reproducible
  • c820d1a: 8281379: Assign package declarations to all jtreg test cases under gc
  • fa0a72c: 8252496: C2: Useless code in MergeMemNode::Ideal
  • 7218d84: 8281567: Remove @throws IOException from X509CRLImpl::getExtension docs
  • fd8a3dc: 8280820: Clean up bug8033699 and bug8075609.java tests: regtesthelpers aren't used
  • 178b962: 8265765: DomainKeyStore may stop enumerating aliases if a constituting KeyStore is empty
  • c5c8c06: 8279822: CI: Constant pool entries in error state are not supported
  • f823bed: 8280007: Enable Neoverse N1 optimizations for Arm Neoverse V1 & N2
  • ... and 70 more: https://git.openjdk.java.net/jdk/compare/4ea6037ea57ce7bbad00ef172dfc3c122b2317fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 10, 2022
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 11, 2022

Going to push as commit 4d64076.
Since your change was applied there have been 89 commits pushed to the master branch:

  • 90939cb: 8281626: NonblockingQueue should use nullptr
  • 3a13425: 8072070: Improve interpreter stack banging
  • 8441d51: 8281419: The source data for the color conversion can be discarded
  • a037b3c: 8281460: Let ObjectMonitor have its own NMT category
  • 65831eb: 8281318: Improve jfr/event/allocation tests reliability
  • eee6a56: 8281522: Rename ADLC classes which have the same name as hotspot variants
  • 84868e3: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths
  • 58c2bd3: 8281536: JFR: Improve jdk.jfr.ContentType documentation
  • 83b6e4b: 8281294: [vectorapi] FIRST_NONZERO reduction operation throws IllegalArgumentExcept on zero vectors
  • 039313d: 8054449: Incompatible type in example code in TreePath
  • ... and 79 more: https://git.openjdk.java.net/jdk/compare/4ea6037ea57ce7bbad00ef172dfc3c122b2317fc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 11, 2022
@openjdk openjdk bot closed this Feb 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2022
@openjdk
Copy link

openjdk bot commented Feb 11, 2022

@prsadhuk Pushed as commit 4d64076.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8047749 branch February 11, 2022 09:39
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2022

Mailing list message from Philip Race on client-libs-dev:

This should have had a CSR.
Valid -> Invalid is fixing a typo for sure but a very significant one in
the context.

Please retroactively submit the CSR.

-phil.

On 2/11/22 1:43 AM, Prasanta Sadhukhan wrote:

@prsadhuk
Copy link
Contributor Author

Mailing list message from Philip Race on client-libs-dev:

This should have had a CSR. Valid -> Invalid is fixing a typo for sure but a very significant one in the context.

Please retroactively submit the CSR.

-phil.

On 2/11/22 1:43 AM, Prasanta Sadhukhan wrote:

CSR raised JDK-8281692

@mlbridge
Copy link

mlbridge bot commented Feb 15, 2022

Mailing list message from Philip Race on client-libs-dev:

CSR reviewed.

-phil

On 2/13/22 8:40 PM, Prasanta Sadhukhan wrote:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants