-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8281585: Remove unused imports under test/lib and jtreg/gc #7426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into |
|
@lkorinth The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. The proof of these changes is in compiling the files - how did you test the non-gc-test changes?
Thanks,
David
|
@lkorinth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Forgot to mention copyright years need updating before integrating! Thanks. |
|
I have a maven project that compiles test/lib and jtreg/gc, so everything changed does compile, I should have mentioned that. I have updated copyright year on all files now as well. |
sspitsyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks,
Serguei
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks.
|
Thanks David and Serguei! /integrate |
|
Going to push as commit 2604a88.
Your commit was automatically rebased without conflicts. |
Remove unused imports under test/lib and jtreg/gc. They create lots of warnings if editing using an IDE. Tests in hotspot_gc passed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7426/head:pull/7426$ git checkout pull/7426Update a local copy of the PR:
$ git checkout pull/7426$ git pull https://git.openjdk.java.net/jdk pull/7426/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7426View PR using the GUI difftool:
$ git pr show -t 7426Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7426.diff