Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281585: Remove unused imports under test/lib and jtreg/gc #7426

Closed
wants to merge 2 commits into from

Conversation

lkorinth
Copy link
Contributor

@lkorinth lkorinth commented Feb 10, 2022

Remove unused imports under test/lib and jtreg/gc. They create lots of warnings if editing using an IDE. Tests in hotspot_gc passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8281585: Remove unused imports under test/lib and jtreg/gc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7426/head:pull/7426
$ git checkout pull/7426

Update a local copy of the PR:
$ git checkout pull/7426
$ git pull https://git.openjdk.java.net/jdk pull/7426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7426

View PR using the GUI difftool:
$ git pr show -t 7426

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7426.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2022

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 10, 2022
@openjdk
Copy link

openjdk bot commented Feb 10, 2022

@lkorinth The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org security security-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Feb 10, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 10, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. The proof of these changes is in compiling the files - how did you test the non-gc-test changes?

Thanks,
David

@openjdk
Copy link

openjdk bot commented Feb 10, 2022

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281585: Remove unused imports under test/lib and jtreg/gc

Reviewed-by: dholmes, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 4ff5824: 8281100: Spurious "variable might not have been initialized" with sealed class switch
  • d254cf2: 8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions
  • 4d64076: 8047749: javadoc for getPathBounds() in TreeUI and BasicTreeUI is incorrect
  • 90939cb: 8281626: NonblockingQueue should use nullptr
  • 3a13425: 8072070: Improve interpreter stack banging
  • 8441d51: 8281419: The source data for the color conversion can be discarded
  • a037b3c: 8281460: Let ObjectMonitor have its own NMT category
  • 65831eb: 8281318: Improve jfr/event/allocation tests reliability
  • eee6a56: 8281522: Rename ADLC classes which have the same name as hotspot variants
  • 84868e3: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/c820d1acb7c6e600a890e4205eef0be8a4c7a791...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 10, 2022
@dholmes-ora
Copy link
Member

Forgot to mention copyright years need updating before integrating! Thanks.

@lkorinth
Copy link
Contributor Author

I have a maven project that compiles test/lib and jtreg/gc, so everything changed does compile, I should have mentioned that. I have updated copyright year on all files now as well.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks,
Serguei

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks.

@lkorinth
Copy link
Contributor Author

Thanks David and Serguei!

/integrate

@openjdk
Copy link

openjdk bot commented Feb 14, 2022

Going to push as commit 2604a88.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 534e557: 8256368: Avoid repeated upcalls into Java to re-resolve MH/VH linkers/invokers
  • 95f198b: 8274980: Improve adhoc build version strings
  • c61d629: 8281553: Ensure we only require liveness from mach-nodes with barriers
  • 2597206: 8280783: Parallel: Refactor PSCardTable::scavenge_contents_parallel
  • 2632d40: 8281637: Remove unused VerifyOption_G1UseNextMarking
  • 46f5229: 8281539: IGV: schedule approximation computes immediate dominators wrongly
  • 1ef45c5: 8280799: С2: assert(false) failed: cyclic dependency prevents range check elimination
  • 483d4b9: 8281505: Add CompileCommand PrintIdealPhase
  • adbe066: 8239927: Product variable PrefetchFieldsAhead is unused and should be removed
  • eff5daf: 8274939: Incorrect size of the pixel storage is used by the robot on macOS
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/c820d1acb7c6e600a890e4205eef0be8a4c7a791...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 14, 2022
@openjdk openjdk bot closed this Feb 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2022
@openjdk
Copy link

openjdk bot commented Feb 14, 2022

@lkorinth Pushed as commit 2604a88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lkorinth lkorinth deleted the _8281585 branch February 14, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org
3 participants