Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255016: ConstantDescs.FALSE claims it represents TRUE #744

Conversation

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Oct 19, 2020

This is a fix for "just a typo" or copy/paste error, but it probably requires a CSR since it changes a normative portion of the spec.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255016: ConstantDescs.FALSE claims it represents TRUE

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/744/head:pull/744
$ git checkout pull/744

@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Oct 19, 2020

/csr

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2020

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@stuart-marks this pull request will not be integrated until the CSR request JDK-8255017 for issue JDK-8255016 has been approved.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Oct 19, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2020

Webrevs

Loading

@bplb
Copy link
Member

@bplb bplb commented Oct 19, 2020

Looks OK.

Loading

bplb
bplb approved these changes Oct 19, 2020
Copy link
Member

@bplb bplb left a comment

Approved.

Loading

Copy link
Member

@JornVernee JornVernee left a comment

Looks good, though I'm not a Reviewer™, I'm the one who introduced this code. It is indeed a typo. Thanks for fixing!

Loading

Copy link
Member

@mlchung mlchung left a comment

+1

Loading

@openjdk openjdk bot removed the csr label Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255016: ConstantDescs.FALSE claims it represents TRUE

Reviewed-by: bpb, jvernee, mchung, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 19, 2020
@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Oct 19, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@stuart-marks Since your change was applied there have been 81 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit bf19581.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants