8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions

[DamonFool]

Hi all,

The following three tests fail with release VMs.

jdk/jfr/event/allocation/TestObjectAllocationInNewTLABEvent.java
jdk/jfr/event/allocation/TestObjectAllocationOutsideTLABEvent.java
jdk/jfr/event/allocation/TestObjectAllocationSampleEventThrottling.java

The failing reason is

STDERR:
Error: VM option 'WhiteBoxAPI' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions.
Error: The unlock option must precede 'WhiteBoxAPI'.

Fix:

1. Add -XX:+UnlockDiagnosticVMOptions
2. Update the copyright year

Testing:

• Affected tests on Linux/x64 with {release, fastdebug}

Thanks.
Best regards,
Jie

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7441/head:pull/7441
$ git checkout pull/7441

Update a local copy of the PR:
$ git checkout pull/7441
$ git pull https://git.openjdk.java.net/jdk pull/7441/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7441

View PR using the GUI difftool:
$ git pr show -t 7441

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7441.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[shipilev]

Ah, dang, sorry! I thought I ran these with release bits, but apparently not.

Looks good and trivial.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281638: jfr/event/allocation tests fail with release VMs after JDK-8281318 due to lack of -XX:+UnlockDiagnosticVMOptions

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Ah, dang, sorry! I thought I ran these with release bits, but apparently not.

Looks good and trivial.

Thanks @shipilev .
/integrate

[openjdk]

Going to push as commit d254cf2.

[openjdk]

@DamonFool Pushed as commit d254cf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Webrevs

• 00: Full (9e4d522a)