Skip to content

8255020: Minor updates to docs jdk.incubator.vector #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Oct 19, 2020

Minor updates, with no specification changes, to the documentation of Vector API.

The compilation of the Vector module was updated to turn on doclint errors for >= protected documentation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ⏳ (3/9 running) ✔️ (9/9 passed)

Issue

  • JDK-8255020: Minor updates to docs jdk.incubator.vector

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/746/head:pull/746
$ git checkout pull/746

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2020

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@PaulSandoz The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Oct 19, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2020

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build change looks ok.

@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255020: Minor updates to docs jdk.incubator.vector

Reviewed-by: erikj, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 14e1e17: 8255004: [JVMCI] expose JVM_ACC_FIELD_INITIALIZED_FINAL_UPDATE
  • f42c032: 8254793: [JVMCI] improve speculation encoding
  • 74ac77e: 8247666: Support Lambda proxy classes in static CDS archive
  • e2e11d3: 8254955: x86: MethodHandlesAdapterBlob is too big
  • 0b51016: 8253660: Need better error report when artifact resolution fails in AotCompiler.java
  • 52cb329: 8254862: lldb in devkit doesn't work

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2020
@PaulSandoz
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@PaulSandoz Since your change was applied there have been 6 commits pushed to the master branch:

  • 14e1e17: 8255004: [JVMCI] expose JVM_ACC_FIELD_INITIALIZED_FINAL_UPDATE
  • f42c032: 8254793: [JVMCI] improve speculation encoding
  • 74ac77e: 8247666: Support Lambda proxy classes in static CDS archive
  • e2e11d3: 8254955: x86: MethodHandlesAdapterBlob is too big
  • 0b51016: 8253660: Need better error report when artifact resolution fails in AotCompiler.java
  • 52cb329: 8254862: lldb in devkit doesn't work

Your commit was automatically rebased without conflicts.

Pushed as commit 0001435.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@PaulSandoz PaulSandoz deleted the JDK-8255020-vector-api-doc-changes branch October 19, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants