Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281738: Create a regression test for checking the 'Space' key activation of focused Button #7460

Closed
wants to merge 7 commits into from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Feb 14, 2022

This test verifies in all platforms and in all 'Look and Feels' that pressing the 'Space' key generates ActionEvent on focused Button or not.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8281738: Create a regression test for checking the 'Space' key activation of focused Button

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7460/head:pull/7460
$ git checkout pull/7460

Update a local copy of the PR:
$ git checkout pull/7460
$ git pull https://git.openjdk.java.net/jdk pull/7460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7460

View PR using the GUI difftool:
$ git pr show -t 7460

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7460.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 14, 2022
@openjdk
Copy link

openjdk bot commented Feb 14, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 14, 2022
@manukumarvs
Copy link
Member Author

@aivanov-jdk Can you please review this.

@mlbridge
Copy link

mlbridge bot commented Feb 14, 2022

… frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE)
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281738: Create a regression test for checking the 'Space' key activation of focused Button

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 124 new commits pushed to the master branch:

  • e1060be: 8281615: Deadlock caused by jdwp agent
  • 6f882de: 8280964: [Linux aarch64] : drawImage dithers TYPE_BYTE_INDEXED images incorrectly
  • 2557ef8: 8282276: Problem list failing two Robot Screen Capture tests
  • 6445ee4: 5041655: (ch) FileLock: negative param and overflow issues
  • 7feabee: 8261407: ReflectionFactory.checkInitted() is not thread-safe
  • 58e1882: 8282042: [testbug] FileEncodingTest.java depends on default encoding
  • 3cb3867: 8281315: Unicode, (?i) flag and backreference throwing IndexOutOfBounds Exception
  • 957dae0: 8280958: G1/Parallel: Unify marking code structure
  • e44d067: 8244593: Clean up GNM/NM after JEP 381
  • 41355e2: 8276686: Malformed Javadoc inline tags in JDK source in /java/util/regex/Pattern.java
  • ... and 114 more: https://git.openjdk.java.net/jdk/compare/4ff5824f5bc13826d2eae1c83094acfcccdb7b8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 22, 2022
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@manukumarvs
Your change (at version 93c4c10) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Feb 22, 2022
Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good. I think these two tests belong together, one complements another.

@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@manukumarvs
Your change (at version 2a1fd64) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

Does anyone have any comments or objections?

@aivanov-jdk
Copy link
Member

Does anyone have any comments or objections?

Having heard no comments, I'm integrating.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

Going to push as commit 941e97c.
Since your change was applied there have been 193 commits pushed to the master branch:

  • 8fec7b8: 8281548: Add escape analysis tracing flag
  • b03d66c: 8282452: Use of Preview API in preview methods should not trigger preview warning for the enclosing class
  • 76398c8: 8279573: compiler/codecache/CodeCacheFullCountTest.java fails with "RuntimeException: the value of full_count is wrong."
  • 31b61f9: 8282311: Fix a typo in javax.lang.model.type.NullType
  • 2c5d266: 8282045: When loop strip mining fails, safepoints are removed from loop anyway
  • 341c8bd: 8267834: Refactor G1CardSetAllocator and BufferNode::Allocator to use a common base class
  • fcce24c: 8281811: assert(_base == Tuple) failed: Not a Tuple after JDK-8280799
  • a95edee: 8281472: JVM options processing silently truncates large illegal options values
  • 44d599a: 8227369: pd_disjoint_words_atomic() needs to be atomic
  • eff396f: 8280713: Related to comment inheritance jdk.javadoc cleanup and refactoring
  • ... and 183 more: https://git.openjdk.java.net/jdk/compare/4ff5824f5bc13826d2eae1c83094acfcccdb7b8f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2022
@openjdk openjdk bot closed this Mar 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 1, 2022
@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@aivanov-jdk @manukumarvs Pushed as commit 941e97c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@manukumarvs manukumarvs deleted the 8281738 branch May 4, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants