8281771: Crash in java_lang_invoke_MethodType::print_signature

[lmesnik]

The crash happens in java.lang.invoke.MethodType. when VM tries to print this objec while rtype and ptypes are not initialized yet. So the fix is just to check if they are not NULL.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8281771: Crash in java_lang_invoke_MethodType::print_signature

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7470/head:pull/7470
$ git checkout pull/7470

Update a local copy of the PR:
$ git checkout pull/7470
$ git pull https://git.openjdk.java.net/jdk pull/7470/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7470

View PR using the GUI difftool:
$ git pr show -t 7470

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7470.diff

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d4b812f8)
• 00: Full (c96f9a40)

[dholmes-ora]

Hi Leonid,

Looks good.

Thanks,
David

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281771: Crash in java_lang_invoke_MethodType::print_signature

Reviewed-by: dholmes, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 622970e: 8281728: Redundant null check in LineNumberInputStream.read
• 11f943d: 8280916: Simplify HotSpot Style Guide editorial changes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Missed the spot?

[dholmes-ora]

Good catch @shipilev !

[lmesnik]

/integrate

[openjdk]

Going to push as commit a24498b.
Since your change was applied there have been 12 commits pushed to the master branch:

• 1aff44b: 8279949: JavaThread::_free_handle_block leaks native memory
• 394ce5f: 8280825: Modules that "provide" ToolProvider should document the name that can be used
• 745f7e7: 8281186: runtime/cds/appcds/DumpingWithNoCoops.java fails
• 1870465: 8281744: x86: Use short jumps in TIG::set_vtos_entry_points
• 2fe0bf6: 8281748: runtime/logging/RedefineClasses.java failed "assert(addr != __null) failed: invariant"
• bc61484: 8280136: Serial: Remove unnecessary use of ExpandHeap_lock
• 2112a9d: 8246033: bin/print_config.js script uses nashorn jjs tool
• 1c12b15: 8281741: [testbug] PrintIdealPhaseTest fails with -Xcomp
• f82866b: 8281555: [macos] Get rid of deprecated Style Masks constants
• 8819f45: 8281722: Removal of PrintIdealLevel
• ... and 2 more: https://git.openjdk.java.net/jdk/compare/b1564624ce454d0df9b2464424b7b5e449481ee6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit a24498b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.