Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8255022: Documentation missing for Vector API zero methods #748

Closed
wants to merge 2 commits into from
Closed

8255022: Documentation missing for Vector API zero methods #748

wants to merge 2 commits into from

Conversation

PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Oct 19, 2020 •
edited by openjdk bot
Loading

The zero methods on IntVector and all other specializations are missing documentation.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ⏳ (1/9 running) ⏳ (1/9 running)

Issue

  • JDK-8255022: Documentation missing for Vector API zero methods

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/748/head:pull/748
$ git checkout pull/748

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2020

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@PaulSandoz To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@PaulSandoz
Copy link
Member Author

/label core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 19, 2020
@PaulSandoz
Copy link
Member Author

/csr

@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@PaulSandoz
The core-libs label was successfully added.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@PaulSandoz this pull request will not be integrated until the CSR request JDK-8255023 for issue JDK-8255022 has been approved.

@mlbridge
Copy link

mlbridge bot commented Oct 19, 2020 •
edited
Loading

Webrevs

iwanowww
iwanowww approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 21, 2020
@openjdk
Copy link

openjdk bot commented Oct 21, 2020 •
edited
Loading

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255022: Documentation missing for Vector API zero methods

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 9ade94b: 8206311: Add docs-javase, docs-reference to CI build
  • 3445031: 8255200: ProblemList com/sun/jdi/EATests.java for ZGC
  • 85a8949: 8254913: Increase InlineSmallCode default from 2000 to 2500 for x64
  • 56ea490: 8233343: Deprecate -XX:+CriticalJNINatives flag which implements JavaCritical native functions
  • 615b759: 8255070: Shenandoah: Use single thread for concurrent CLD liveness test
  • 6020991: 8255068: [JVMCI] errors during compiler creation can be hidden
  • 8d9e6d0: 8255041: Zero: remove old JSR 292 support leftovers
  • 0efdde1: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic)
  • 365f19c: 8254790: SIGSEGV in string_indexof_char and stringL_indexof_char intrinsics
  • f813a28: 8254692: (se) Clarify the behaviour of the non-abstract SelectorProvider::inheritedChannel
  • ... and 77 more: https://git.openjdk.java.net/jdk/compare/60f63ec811d834d9f1a7468a5552ffa12568b765...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2020
@PaulSandoz
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2020
@openjdk
Copy link

openjdk bot commented Oct 21, 2020

@PaulSandoz Since your change was applied there have been 87 commits pushed to the master branch:

  • 9ade94b: 8206311: Add docs-javase, docs-reference to CI build
  • 3445031: 8255200: ProblemList com/sun/jdi/EATests.java for ZGC
  • 85a8949: 8254913: Increase InlineSmallCode default from 2000 to 2500 for x64
  • 56ea490: 8233343: Deprecate -XX:+CriticalJNINatives flag which implements JavaCritical native functions
  • 615b759: 8255070: Shenandoah: Use single thread for concurrent CLD liveness test
  • 6020991: 8255068: [JVMCI] errors during compiler creation can be hidden
  • 8d9e6d0: 8255041: Zero: remove old JSR 292 support leftovers
  • 0efdde1: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic)
  • 365f19c: 8254790: SIGSEGV in string_indexof_char and stringL_indexof_char intrinsics
  • f813a28: 8254692: (se) Clarify the behaviour of the non-abstract SelectorProvider::inheritedChannel
  • ... and 77 more: https://git.openjdk.java.net/jdk/compare/60f63ec811d834d9f1a7468a5552ffa12568b765...master

Your commit was automatically rebased without conflicts.

Pushed as commit 60d3fa2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@PaulSandoz PaulSandoz deleted the JDK-8255022-vector-api-docs-zero-methods branch October 22, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwanowww iwanowww iwanowww approved these changes

@jddarcy jddarcy jddarcy approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulSandoz @iwanowww @jddarcy